refactor: splitting out data-api-repository into it's own module
#4181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `models` I've intentionally opted to copy rather than copy and aliqs the old ones since the next step will be running find/replace onthe import paths - so I'm not convinced it's worth the aliasing time
This contains a Commit SHA for the import source, so shouldn't be specific to RM
…repository` temporarily This'll facilitate moving the files, intentionally staging this to make merge conflicts easier?
…ocal logger The logger instance `logging.Log` is passed in, so this is no different - but means this can be refactored out
…o the repository module This allows other things to use it, with tweaks, as needed.
…ow sits within `data-api-repository`
Breaking ChangesNo Breaking Changes were found 👍 |
Summary of ChangesNo Breaking or Non-Breaking Changes were found 👍 |
New Resource ID Segments containing Static IdentifiersNo new Resource ID Segments containing Static Identifiers were identified in the set of changes 🤙. |
manicminer
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted whilst reviewing @manicminer's Microsoft Graph PR (#4167) I realised that it's going to be easier if this is split out ahead of time, to differentiate what's needed/changed for Graph (so that we can ensure this is threaded through everywhere as needed).
This PR allows the three data related tools (
data-api,importer-msgraph-metadataandimporter-rest-api-specs) to use the same models and repository for interacting with the data (importer-rest-api-specsuses both now, the other two will be refactored in a bit)