Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/importer-rest-api-specs: refactoring the constants and the models/dictionary tests to use the new tests assertion helpers [Stage 8 Part 2] #3814

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

tombuildsstuff
Copy link
Contributor

This PR refactors both the tests covering parsing Constants and Dictionaries within Models to use the new test assertion helpers, which'll make migrating to the new Data API SDK models easier.

This is Part 2 for Stage 8 of #3754

…e the test helper

This also simplifies the Swagger parsers to remove unnecessary wrapper models
@tombuildsstuff tombuildsstuff requested a review from a team February 19, 2024 09:47
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦕

Base automatically changed from refactor/8-testassertion-helpers to main February 19, 2024 18:05
@tombuildsstuff tombuildsstuff merged commit 63e57fc into main Feb 19, 2024
2 checks passed
@tombuildsstuff tombuildsstuff deleted the refactor/8-testassertion-helpers-2 branch February 19, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor tool/importer-rest-api-specs Swagger Data Importer issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants