Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/importer-rest-api-specs: updating (half) the tests to use the new test assertion helpers #3808

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

tombuildsstuff
Copy link
Contributor

This PR updates some of the Swagger Parser tests over to using the new test helper tooling - which'll make refactoring this project over to using the new Data API SDK types easier in the future (and has the side-benefit of halving the amount of code needed per test).

Given the number of tests which need to be converted over I've opted to split this PR in two - with constants and models still to go.

Part of #3754

@tombuildsstuff tombuildsstuff requested a review from a team February 16, 2024 14:32
@tombuildsstuff tombuildsstuff force-pushed the refactor/8-testassertion-helpers branch from 83069cc to 9ee1b2d Compare February 19, 2024 07:47
@@ -0,0 +1,80 @@
package parser
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file exists only temporarily/until the SDK migration is completed - it just means we can reuse these helper functions early

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚚

@tombuildsstuff tombuildsstuff merged commit cf46ec8 into main Feb 19, 2024
2 checks passed
@tombuildsstuff tombuildsstuff deleted the refactor/8-testassertion-helpers branch February 19, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor tool/importer-rest-api-specs Swagger Data Importer issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants