Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for iso_storage_pool in an additional_iso_files block #252

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

mpywell
Copy link
Contributor

@mpywell mpywell commented Feb 1, 2024

Add validation of iso_storage_pool in an additional_iso_files block where an iso_url is specified for upload.

...
  additional_iso_files {
    device           = "ide0"
    iso_url          = "https://fedorapeople.org/groups/virt/virtio-win/direct-downloads/stable-virtio/virtio-win.iso"
    iso_checksum     = "none"
    unmount          = true
  }
...

Packer build runs without iso_storage_pool specified for the above block now output

Error: 1 error(s) occurred:

* when specifying iso_url in an additional_iso_files block, iso_storage_pool must also be specified

  on 197.pkr.hcl line 32:
  (source code not available)

Resolves issue described in #197

@mpywell mpywell requested a review from a team as a code owner February 1, 2024 23:10
@hashicorp-cla
Copy link

hashicorp-cla commented Feb 1, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the patch @mpywell!

Hopefully this fixes #197 for everyone.

I'll see to release the plugin early next week, this way the fix will be broadly available.

@lbajolet-hashicorp lbajolet-hashicorp merged commit e84be26 into hashicorp:main Feb 2, 2024
12 checks passed
@BonusPlay
Copy link

@lbajolet-hashicorp as far as I can see there hasn't been a single release since this has been merged (v1.1.7 released on Jan 24, while this has been merged on Feb 2). Could we get a release?

@lbajolet-hashicorp
Copy link
Contributor

Hi @BonusPlay,

Looks like I forgot to release it when I said I would, sorry about that.

I'll release a version tomorrow, I've put a note in my calendar so I don't forget, thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants