builder: don't enable iothread for all scsi #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nywilken
approved these changes
Jan 11, 2024
| @@ -286,7 +286,7 @@ func generateProxmoxDisks(disks []diskConfig) proxmox.QemuDevices { | |||
| setDeviceParamIfDefined(devs[idx], "cache", disks[idx].CacheMode) | |||
| setDeviceParamIfDefined(devs[idx], "format", disks[idx].DiskFormat) | |||
|
|
|||
| if devs[idx]["type"] == "scsi" || devs[idx]["type"] == "virtio" && | |||
| if (devs[idx]["type"] == "scsi" || devs[idx]["type"] == "virtio") && | |||
When a SCSI disk is specified for a configuration, the iothread argument should only be set if requested, and not all the time. Because of a priority problem though, all the SCSI disks ended-up with iothread set, even if it was not requested. This commit fixes that, and ensures it is fixed by adding some tests for it.
lbajolet-hashicorp
force-pushed
the
no_iothread_scsi_not_requested
branch
from
1f8645a to
6303c37
Compare
|
Would you mind tagging a new release so we can use this fix? |
|
Hi @xoxys, Good call, I'll release Proxmox this week. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a SCSI disk is specified for a configuration, the iothread argument should only be set if requested, and not all the time.
Because of a priority problem though, all the SCSI disks ended-up with iothread set, even if it was not requested.
This commit fixes that, and ensures it is fixed by adding some tests for it.
Fixes: #248