Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update machine docs without i440fx #159

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Conversation

lbajolet-hashicorp
Copy link
Contributor

The i440fx machine type is advertised as supported by the Proxmox API client incorrectly, as it is then rejected by proxmox since the i440fx machine type is only supported with a version identifier, which will then be rejected by the API client.

To avoid confusion in the docs, we remove the reference to i440fx, and only document the pc and q35 values as they are both accepted by proxmox and the API client.

Related to #154

@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner February 13, 2023 20:22
The i440fx machine type is advertised as supported by the Proxmox API
client incorrectly, as it is then rejected by proxmox since the i440fx
machine type is only supported with a version identifier, which will
then be rejected by the API client.

To avoid confusion in the docs, we remove the reference to i440fx, and
only document the `pc` and `q35` values as they are both accepted by
proxmox and the API client.
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbajolet-hashicorp lbajolet-hashicorp merged commit c8743bc into main Feb 13, 2023
@lbajolet-hashicorp lbajolet-hashicorp deleted the fix_machine_docs branch February 13, 2023 22:08
@lbajolet-hashicorp lbajolet-hashicorp added the documentation Improvements or additions to documentation label Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants