Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return lexer errors only if they affect the current cursor position #445

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luantranminh
Copy link

@luantranminh luantranminh commented Feb 6, 2025

Currently, when doing completion in a file that has lexer errors (like unclosed quotes), completion is not working perfectly when applying. This creates a poor user experience as users often need completion while typing incomplete code.

Example:

resource "a" {
  one {
    sr  # User wants completion here
    two {
      name = "ok  # Unclosed quote
    }
  }
}

After selecting completion item, text will append instead of replacing, causing duplication:

resource "a"  {
  one {
    ssrc  # 'src' was appended to 'sr' instead of replacing it
    two {
      name = "ok  
    }
  }
}

Expected behavior:

  • Completion should correctly replace existing text rather than appending
  • Only append completion if the lexer error affects the current cursor position

@luantranminh luantranminh requested a review from a team as a code owner February 6, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant