Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hip-551.md #1090

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

ty-swirldslabs
Copy link
Contributor

Add new updates to HIP-551 after implementation discussions

Description:
Updated information and implementation description into HIP-551

Add new updates to HIP-551 after implementation discussions
Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for hedera-hips ready!

Name Link
🔨 Latest commit 53cf6a9
🔍 Latest deploy log https://app.netlify.com/sites/hedera-hips/deploys/67c06df02825590007b12495
😎 Deploy Preview https://deploy-preview-1090--hedera-hips.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mgarbs mgarbs requested a review from netopyr January 7, 2025 17:08
@mgarbs mgarbs requested a review from SimiHunjan January 23, 2025 00:14
@mgarbs
Copy link
Collaborator

mgarbs commented Feb 3, 2025

Hi team,

Hope you're all doing well! Just wanted to follow up on PR #Update hip-551.md. It's fantastic to see the engagement so far, thank you for all of your inputs.

There are still 3 unresolved discussions that require your perspectives. The insights which each of you hold are extremely valuable to shaping this project. If you could find some time to go through these discussions and share your views, that would be highly appreciated.

Thanks again and looking forward to your inputs!

Best,
Michael
@SimiHunjan - There's an unresolved discussion from 2025-01-17. Could you please take a look and either resolve or provide additional context? Link to discussion

@SimiHunjan - There's an unresolved discussion from 2025-01-17. Could you please take a look and either resolve or provide additional context? Link to discussion

@SimiHunjan
Copy link
Contributor

I resolved the conversations. Thanks for the follow-up!

kimbor and others added 3 commits February 4, 2025 15:55
Signed-off-by: Michael Heinrichs <[email protected]>
steven-sheehy
steven-sheehy previously approved these changes Feb 19, 2025
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Michael Heinrichs <[email protected]>
Signed-off-by: Michael Heinrichs <[email protected]>
Copy link
Contributor

@jnels124 jnels124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy
Copy link
Member

Looks like @ty-swirldslabs needs to GPG sign and DCO signoff his commits for it to merge.

@mgarbs
Copy link
Collaborator

mgarbs commented Feb 26, 2025

@ty-swirldslabs merging is blocked until the commits have verified signatures on them. There are two commits in this list that need signatures: https://github.com/hashgraph/hedera-improvement-proposal/pull/1090/commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants