lower: fix Graphviz output and settings #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the `SimplifyGraphPass` to the optimise passes configuration to run before and after the `CleanupLocalPass`. This increases the optimisation of the graph by simplifying the graph before and after the local cleanup.
kontheocharis
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a few issues with the lowering settings being propagated and with the graphviz
output format which unexpectedly changed the block ids.
Finally, the
SimplifyGraphPassis now run before and after theCleanupLocalPassto ensure that now-empty blocks are also removedafter the lowering.
Commits
LoweringSettingsmerge should inherit rhs valuesSimplifyGraphPasspre & postCleanupLocalPass