Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: represent bearing as geographic terms #1009

Merged
merged 3 commits into from
Feb 2, 2025
Merged

feat: represent bearing as geographic terms #1009

merged 3 commits into from
Feb 2, 2025

Conversation

GuyKe5
Copy link
Collaborator

@GuyKe5 GuyKe5 commented Jan 15, 2025

Description

Translate bearing to geographic terms

screenshots

image

@GuyKe5 GuyKe5 requested a review from NoamGaash as a code owner January 15, 2025 14:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025 •
edited
Loading

Preview: https://s3.amazonaws.com/noam-gaash.co.il/12810084685/open-bus/290/index.html
Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/12810084685/open-bus/290/storybook/index.html
Test Report (if available): 'https://s3.amazonaws.com/noam-gaash.co.il/12810084685/open-bus/d8e2444cd315e7ba177aa70300286362a1f026e8/test-results/index.html'

NoamGaash
NoamGaash reviewed Jan 16, 2025
View reviewed changes
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Can you wrap the direction with t(....) to make sure it's translated?
Also please pay attention to the linter comments in your code
thanks! 👏

@NoamGaash NoamGaash changed the title Translate bearing to geographic terms feat: represent bearing to geographic terms Jan 16, 2025
@NoamGaash NoamGaash changed the title feat: represent bearing to geographic terms feat: represent bearing as geographic terms Jan 16, 2025
@NoamGaash
Copy link
Member

Cool!
image

@NoamGaash NoamGaash merged commit c74509a into main Feb 2, 2025
18 of 20 checks passed
@NoamGaash NoamGaash deleted the TranslateBearingToGeographicTerms branch February 2, 2025 06:57
@NoamGaash
Copy link
Member

@all-contributors please add GuyKe5 to code
Thanks!

@github-actions github-actions bot mentioned this pull request Feb 2, 2025
Open
@allcontributors AllContributors
Copy link
Contributor

@NoamGaash

Could not find the user [GuyKe5](https://github.com/GuyKe5) on github.

@NoamGaash
Copy link
Member

@all-contributors please add @GuyKe5 to code
Thanks!

@allcontributors allcontributors bot mentioned this pull request Feb 2, 2025
Merged
@allcontributors AllContributors
Copy link
Contributor

@NoamGaash

I've put up a pull request to add @GuyKe5! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoamGaash NoamGaash NoamGaash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuyKe5 @NoamGaash @Guy5ke