bump(chart): bump Whereabouts to v0.8.0

[WebberHuang1118]

Problem:
Bump Whereabout to v0.8.0

Solution:
Bump Whereabout to v0.8.0

Additional Context:
This PR can't be merged until the path of the extra manifest is changed to v1.4.1 (this should happen after v1.4.1 release)

Related Issue:
https://github.com/harvester/security/issues/62

Test plan:
Deploy to running Harvester

• Building Harvester cluster with v1.4.1-rc1
• Enabling Storage Network
• Creating a VM
• Applying new Whereabouts CRD
  • $ kubectl apply -f deploy/charts/harvester/dependency_charts/whereabouts/crds/whereabouts.cni.cncf.io_ippools.yaml
  • $ kubectl apply -f deploy/charts/harvester/dependency_charts/whereabouts/crds/whereabouts.cni.cncf.io_overlappingrangeipreservations.yaml
• Updating Whereabouts from v0.7.0 to v0.8.0
  • Adding mangedchart harvester's spec.values with

  whereabouts:
    enabled: true
    image:
      pullPolicy: IfNotPresent
      repository: ghcr.io/k8snetworkplumbingwg/whereabouts
      tag: "v0.8.0"
  

• Checking if daemoset harvester-whereabouts successfully deployed image ghcr.io/k8snetworkplumbingwg/whereabouts:v0.8.0
• Checking if Longhorn backing-image-manager-xxxx pods, instance-manager-xxxx pods, and backing-image-ds-xxxx pods (only appearing during uploading) have interface lhnet1 and its IP in the assigned range
• The VM can stop/restart successfully

Building New Harvester with this PR

• Building ISO from this branch, and creating the Harvester cluster with the ISO
• After Harvester brought up, Check if daemonset harvester-whereabouts successfully deploying image ghcr.io/k8snetworkplumbingwg/whereabouts:v0.8.0
• Enabling Storage Network
• Checking if Longhorn backing-image-manager-xxxx pods, instance-manager-xxxx pods, and backing-image-ds-xxxx pods (only appearing during uploading) have interface lhnet1 and its IP in the assigned range
• Checking image upload
• Creating VM from uploaded image

Upgrade from v1.4.1 to this PR

• Building Harvester cluster with v1.4.1
• Enabling Storage Network
• Creating a VM
• Upgrading Harvester from v1.4.1 to ISO built from this PR
• Checking if daemoset harvester-whereabouts successfully deployed image ghcr.io/k8snetworkplumbingwg/whereabouts:v0.8.0
• Checking if Longhorn backing-image-manager-xxxx pods, instance-manager-xxxx pods, and backing-image-ds-xxxx pods (only appearing during uploading) have interface lhnet1 and its IP in the assigned range
• The VM can stop/restart successfully

[WebberHuang1118]

Whereabouts' CRD ippools and overlappingrangeipreservations are not updated in the upgrade path, and this would break LH pods' creation

Found a temporary workaround to move deploy/charts/harvester/dependency_charts/whereabouts/crds into deploy/charts/harvester/dependency_charts/whereabouts/templates, however, this seems to violate the convention

Thanks @starbops for pointing out a similar issue, I will try the proposed method

[rrajendran17]

@WebberHuang1118 hope we need another PR for this to bump it to v0.8.0

harvester/go.mod

Line 80 in 867a873

github.com/k8snetworkplumbingwg/whereabouts v0.7.0

.

I will take care of the PR and merge once this PR is merged.

[starbops]

I have a general question: I saw the README in our whereabouts chart mentioned that:

Original Whereabouts CNI Helm charts is out of date. It still used the legacy method to run Whereabouts CNI. We update the charts from Cronjob to DaemonSet to fit new version of Whereabouts CNI.

But when I looked at the upstream repository, it seemed that they do actively maintained the chart in here. There is even a new CRD that we don't include. Do we want to reevaluate whether to use the upstream chart?

[WebberHuang1118]

@WebberHuang1118 hope we need another PR for this to bump it to v0.8.0

harvester/go.mod

Line 80 in 867a873

github.com/k8snetworkplumbingwg/whereabouts v0.7.0

.
I will take care of the PR and merge once this PR is merged.

Hi @rrajendran17

Do you mean we should have another PR for it?

@WebberHuang1118 Yes I thought so, the current PR is for bumping whereabouts deployment and

harvester/go.mod

Line 80 in 867a873

github.com/k8snetworkplumbingwg/whereabouts v0.7.0

is for whereabouts code/api usage and it should also be bumped as well. Am I missing something ?

[WebberHuang1118]

I have a general question: I saw the README in our whereabouts chart mentioned that:

Original Whereabouts CNI Helm charts is out of date. It still used the legacy method to run Whereabouts CNI. We update the charts from Cronjob to DaemonSet to fit new version of Whereabouts CNI.

But when I looked at the upstream repository, it seemed that they do actively maintained the chart in here. There is even a new CRD that we don't include. Do we want to reevaluate whether to use the upstream chart?

Hi @starbops

The chart deployment/whereabouts-chart and the new CRD only exist in the master branch, maybe we can refer to this for the next release.

For the manifest update, I currently checked whereabouts/doc.

[WebberHuang1118]

@WebberHuang1118 hope we need another PR for this to bump it to v0.8.0

harvester/go.mod

Line 80 in 867a873

github.com/k8snetworkplumbingwg/whereabouts v0.7.0

.
I will take care of the PR and merge once this PR is merged.

@rrajendran17
Let's create the related PR once this one is merged, thanks.

[WebberHuang1118]

Hi @bk201 @starbops @rrajendran17

The extra manifest has been changed to v1.4.1, and I have also re-tested the upgrade path.

If everything is fine, this PR should be ready to be merged. Please help to check it. Thanks.

[starbops]

LGTM, thanks.

[rrajendran17]

LGTM,Thanks