Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow cargo deny to use default features #46

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

peasee
Copy link
Contributor

@peasee peasee commented Jan 29, 2024

Related Tasks

N/A

Depends on

N/A

What

Allows cargo-deny to install with its default features.

Why

One of the feature flags in cargo-deny, reqwest/rustls-tls-webpki-roots, is used to support the HTTP requests the tool makes. When disabled, it throws the error:

[ERROR] failed to fetch advisory database https://github.com/RustSec/advisory-db: An IO error occurred when talking to the server: error sending request for url (https://github.com/RustSec/advisory-db/info/refs?service=git-upload-pack): error trying to connect: invalid URL, scheme is not http

Allowing the default flags prevents this error, and also enables the use of OS certificate stores for validating HTTP certificates.

@peasee peasee self-assigned this Jan 29, 2024
@peasee peasee requested a review from a team as a code owner January 29, 2024 00:38
Copy link

@TanyaSrinidhi TanyaSrinidhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@peasee peasee merged commit c792603 into main Jan 30, 2024
1 check passed
@peasee peasee deleted the fix/cargo-deny-enable-features branch January 30, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants