Webhooks execution #922
Merged
Webhooks execution #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for harness-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for harness-xd-review ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sans-harness
force-pushed
the
webhooks-execution
branch
from
0fabb7c to
bb511fc
Compare
|
Few issues observed in the video:
|
Comment on lines
+11
to
+12
| { id: 0, title: t('views:repos.details', 'Details'), to: 'details' }, | ||
| { id: 1, title: t('views:repos.executions', 'Executions'), to: 'executions' } |
There was a problem hiding this comment.
navigation paths should not be hardcoded. use routes object instead
| return ( | ||
| <SandboxLayout.Main> | ||
| <SandboxLayout.Content maxWidth="2xl"> | ||
| <h1 className="text-2xl font-medium text-foreground-1 mb-4">Order Status Update Webhook</h1> |
There was a problem hiding this comment.
Is the title of the page hardcoded? should not be.
| <SandboxLayout.Content maxWidth="2xl"> | ||
| <h1 className="text-2xl font-medium text-foreground-1 mb-4">Order Status Update Webhook</h1> | ||
| <Text> | ||
| This webhook triggers every time an order status is updated, sending data to the specified endpoint for |
| ]} | ||
| primaryButton={{ | ||
| label: t('views:webhookData.create', 'Create webhook'), | ||
| to: `${toRepoWebhooks(repo_ref)}/create` |
There was a problem hiding this comment.
no hardcoded routes
sans-harness
force-pushed
the
webhooks-execution
branch
from
8c84fcb to
14906b9
Compare
Screen.Recording.2025-02-03.at.10.59.59.AM.movFixes flciker and page jumping issue. Lets take up |
abhinavrastogi-harness
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webhook-execution-listpage.Screen.Recording.2025-01-31.at.3.51.39.PM.mov