[Temporary] Add TODO comments

Signed-off-by: Hanwen <[email protected]>
hanwen-pcluste · Jan 25, 2024 · 41c26fa · 41c26fa
1 parent 6af080a
commit 41c26fa
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 1 deletion.
diff --git a/...books/aws-parallelcluster-platform/resources/install_packages/install_packages_redhat8.rb b/...books/aws-parallelcluster-platform/resources/install_packages/install_packages_redhat8.rb
@@ -23,6 +23,7 @@ def default_packages
   # environment-modules required by EFA, Intel MPI and ARM PL
   # Removed libssh2-devel from base_packages since is not shipped by RedHat 8 and in conflict with package libssh-0.9.6-3.el8.x86_64
   # iptables needed for IMDS setup
+  # ToDo send a message in pcluster-interest to see if the package removal/addition is ok
   %w(vim ksh tcsh zsh openssl-devel ncurses-devel pam-devel net-tools openmotif-devel
      libXmu-devel hwloc-devel libdb-devel tcl-devel automake autoconf libtool
      httpd boost-devel mlocate R atlas-devel

diff --git a/cookbooks/aws-parallelcluster-platform/resources/install_packages/install_packages_rocky8.rb b/cookbooks/aws-parallelcluster-platform/resources/install_packages/install_packages_rocky8.rb
@@ -47,6 +47,7 @@ def kernel_source_package_version
 def default_packages
   # environment-modules required by EFA, Intel MPI and ARM PL
   # iptables needed for IMDS setup
+  # ToDo send a message in pcluster-interest to see if the package removal/addition is ok
   packages = %w(vim ksh tcsh zsh openssl-devel ncurses-devel pam-devel net-tools openmotif-devel
      libXmu-devel hwloc-devel libdb-devel tcl-devel automake autoconf libtool
      httpd boost-devel mlocate R atlas-devel

diff --git a/kitchen.docker.yml b/kitchen.docker.yml
@@ -87,7 +87,7 @@ platforms:
       image: <% if ENV['KITCHEN_RHEL8_IMAGE'] %> <%= ENV['KITCHEN_RHEL8_IMAGE'] %> <% else %>registry.access.redhat.com/ubi9/ubi <% end %>
       intermediate_instructions:
         - RUN chmod +t /tmp
-        - RUN yum install libxcrypt-compat -y
+        - RUN yum install libxcrypt-compat -y # ToDo: more investigation on why
     attributes:
       cluster:
         base_os: rhel9

diff --git a/kitchen.ec2.yml b/kitchen.ec2.yml
@@ -161,6 +161,7 @@ platforms:
       # Use the RedHat 8 AMI most similar to the base AMI used to build the ParallelCluster image
       image_id: <%= ENV['KITCHEN_RHEL9_AMI'] %>
       <% else %>
+      # ToDo AMI license
       image_search:
         name: <% if ENV['KITCHEN_PHASE']=='install' %>RHEL-9.3.*_HVM*<% else %><%= pcluster_prefix %>-rhel9-hvm-*<% end %>
         architecture: <%= ENV['KITCHEN_ARCHITECTURE'] %>