Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/order cancel #63

Merged
merged 12 commits into from
Oct 24, 2023
Merged

Feature/order cancel #63

merged 12 commits into from
Oct 24, 2023

Conversation

e-build
Copy link
Contributor

@e-build e-build commented Oct 24, 2023 •
edited
Loading

๐Ÿ“Œ ์š”์•ฝ

  • ์ฃผ๋ฌธ ์ทจ์†Œ ๊ตฌํ˜„

๐Ÿ“• ๋ฌด์—‡์„ ์ž‘์—…ํ•˜์…จ๋‚˜์š”?

  • ๋ฒ„๊ทธ ์ˆ˜์ •
  • ๊ธฐ๋Šฅ ๊ฐœ๋ฐœ
  • ๋ฆฌํŒฉํ„ฐ๋ง
  • ๋ฌธ์„œ
  • ํ…Œ์ŠคํŠธ
  • ๋นŒ๋“œ ๋ฐ ํ™˜๊ฒฝ์„ค์ • ๊ด€๋ จ ์ž‘์—…
  • ๊ทธ ์™ธ์˜ ๊ฒฝ์šฐ ๊ฐ„๋žตํžˆ ๊ธฐ์ˆ ํ•ด์ฃผ์„ธ์š”

๐Ÿ“– ๋ณ€๊ฒฝ์‚ฌํ•ญ

  • Kotlin - JUnit5 ๋‹จ์œ„ ํ…Œ์ŠคํŠธ ์‹œ ํ™œ์šฉ์„ ์œ„ํ•œ Mock ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ ์ถ”๊ฐ€ - MockK
  • claim ๋„๋ฉ”์ธ ์ถ”๊ฐ€ํ•˜์—ฌ '์ฃผ๋ฌธ ์ทจ์†Œ' ๊ตฌํ˜„
  • ๋ฆฌํŒฉํ† ๋ง
    • Application ๊ณ„์ธต์—์„œ Presentation์˜ DTO์— ๋Œ€ํ•œ ์˜์กด ์ œ๊ฑฐ. Mapper ๋‚ด์— ํ™•์žฅํ•จ์ˆ˜๋กœ ๋ณ€ํ™˜ ์ž‘์—… ์ฒ˜๋ฆฌ

โœ… ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ํ™˜๊ฒฝ๋ณ€์ˆ˜๋ฅผ ์ž„์˜๋กœ ์ˆ˜์ •ํ•˜์ง€ ์•Š์•˜๋‚˜์š”?
  • ๋ถˆํ•„์š”ํ•œ ๋กœ๊ทธ๋ฅผ ์ง€์šฐ์…จ๋‚˜์š”?

jimmy.lee added 12 commits October 23, 2023 19:10
feat: ์ฃผ๋ฌธ ์ทจ์†Œ ์ถ”๊ฐ€
449a985
fix: payment > bankAccount - build ์˜ค๋ฅ˜ ์ˆ˜์ •
7cb7554
refactor: Order ๋„๋ฉ”์ธ > reader, writer ๋„๋ฉ”์ธ ๋ ˆ์ด์–ด๋กœ ์ด๋™
7574470
refactor: Payment ๋„๋ฉ”์ธ > reader, writer ๋„๋ฉ”์ธ ๋ ˆ์ด์–ด๋กœ ์ด๋™
3f534fd
chore: api ๋ชจ๋“ˆ > MockK ์˜์กด์„ฑ ์ถ”๊ฐ€
d6aa83f
feat: order > ์ฃผ๋ฌธ ์ทจ์†Œ ์‚ฌ์œ  ์ถ”๊ฐ€
5a584f9
test: claim > add OrderCancelServiceTest tc
6b0d15a
test: claim > add OrderCancelValidator tc
7c026ab
refactor: order > application, domain servivce rename
44e21af
refactor: order > ์œ„์ƒ ์ •๋ฆฌ
0962b70 
- application: request/response dto ์˜์กด ์ œ๊ฑฐ
test: claim API tc ์ถ”๊ฐ€
8559262
refactor: payment > application ๊ณ„์ธต presentation dto ์˜์กด ์ œ๊ฑฐ
166e2d9
@e-build e-build requested review from sm9171, 5Hanui and iamzin October 24, 2023 13:03
@e-build e-build self-assigned this Oct 24, 2023
@github-actions
Copy link

Test Results

0 testsโ€‚ ยฑ0โ€‚โ€ƒโ€ƒ0 โœ”๏ธ ยฑ0โ€‚โ€ƒโ€ƒ0s โฑ๏ธ ยฑ0s
0 suites ยฑ0โ€‚โ€ƒโ€ƒ0 ๐Ÿ’ค ยฑ0โ€‚
0 filesโ€„โ€‚ ยฑ0โ€‚โ€ƒโ€ƒ0 โŒ ยฑ0โ€‚

Results for commit 166e2d9.โ€ƒยฑ Comparison against base commit 8bdcd05.

@e-build e-build merged commit 32f1010 into develop Oct 24, 2023
5 of 6 checks passed
@e-build e-build deleted the feature/order-cancel branch October 24, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sm9171 sm9171 Awaiting requested review from sm9171

@5Hanui 5Hanui Awaiting requested review from 5Hanui

@iamzin iamzin Awaiting requested review from iamzin

Assignees

@e-build e-build

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@e-build