Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: RSA keys must use --bare #132

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

pinheadmz
Copy link
Member

See #131 and #126 (comment)

We need to nip this in the bud by requiring RSA key users add --bare to their claim. I suppose we could also rip out the goosig code, but this should suffice for now.

@pinheadmz pinheadmz merged commit 425a392 into handshake-org:master Apr 6, 2021
@seidtgeist
Copy link

seidtgeist commented May 4, 2021

@pinheadmz Anything I can do if I submitted my claim without --bare?

I got this in hsd’s log output after sending the bare base64 string:

[error] (node) Verification failure: txn-already-in-mempool (code=alreadyknown score=0 hash=ac1b13c2dcec18f6e81be8782354acd028b45258d45028500454791066875d35)
[warning] (node) Verification failed for proof: ac1b13c2dcec18f6e81be8782354acd028b45258d45028500454791066875d35.
[warning] (node) Attempting to broadcast anyway...

@pinheadmz
Copy link
Member Author

@seidtgeist #133

@seidtgeist
Copy link

@pinheadmz Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants