Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix save profile ui bug #194

Merged
merged 2 commits into from
Mar 29, 2018
Merged

Fix save profile ui bug #194

merged 2 commits into from
Mar 29, 2018

Conversation

nischayv
Copy link
Member

closes #193

@nischayv nischayv requested a review from KrashLeviathan March 29, 2018 05:09
Copy link
Member

@KrashLeviathan KrashLeviathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one request that's kind of related to these changes. The dialog that pops up when you save says, "Changes have been saved successfully" but it has a Cancel button, which doesn't make sense. My suggestion is to either

A) change the dialog to text to some confirmation message, like "Press Continue to confirm changes or Cancel to undo."

or B) change the dialog to a simple confirmation "Snackbar" component at the bottom of the page.

or C) just remove the Cancel button from the dialog box and leave the message the same.

or D) change the Cancel button to say Undo.

@nischayv
Copy link
Member Author

@KrashLeviathan Ya that's a good point. I feel the same way about the cancel button. I just decided to not worry about it for now and reused a modal that I had created for generic use. I can change it to a snackbar since I think it does make the UI a little more seamless.

@KrashLeviathan KrashLeviathan merged commit 6b7f1c8 into master Mar 29, 2018
@KrashLeviathan KrashLeviathan deleted the bugfix-193 branch March 29, 2018 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update profile UI doesn't work correctly
2 participants