Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request #2 #2

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Pull request #2 #2

wants to merge 13 commits into from

Conversation

Hannu1
Copy link

@Hannu1 Hannu1 commented Feb 9, 2016

settings.py to replace configure.py, dev_id.devid and client.properties
Fixed bugs that were discussed in emails:

  • playlist_manager was saving update_time and playlist_id too early. Could cause the device to not download new files after a disconnection.
  • downloader was not fsyncing files to disc before rename. Could cause the device to think it had complete files when it actually had corrupted ones.
  • Broken exception SSLError caused uncaught exceptions

Added new improvement ideas/notes etc.

More complete changes can be seen in commit messages.

Hannu Lahtinen added 13 commits February 7, 2016 18:41
Attempted to fix a bug where exceptions without messages cause problems. MINOR
Fixed a bug where playlist might get half downloaded, throw an exception and require a PI reboot to continue. CRITICAL
Added setting to give your own crt file for the requests.
Test commit. (Easiest way to move the changes to my pi for testing)
- a file would be downloaded and renamed but not all data was synced to disk,
- power failed,
- after a reboot the file would be on disk but would have corrupted data
- client would think the file was ok and tried display the corrupted file
Merge pull request #2 from nullpointer08/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant