Replace deprecated User::isBlocked & ::newFromId (#5)

ERM36615 Co-authored-by: hslater <[email protected]>
hallowelt · Feb 4, 2025 · 4e06777 · 4e06777
1 parent 372071a
commit 4e06777
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/BaseNotification.php b/src/BaseNotification.php
@@ -198,17 +198,19 @@ public function getUser() {
 	 * @param array $users
 	 */
 	protected function addAffectedUsers( $users ) {
+		$services = MediaWikiServices::getInstance();
+		$userFactory = $services->getUserFactory();
+		$pm = $services->getPermissionManager();
 		foreach ( $users as $user ) {
 			if ( is_numeric( $user ) ) {
-				$user = User::newFromId( intval( $user ) );
+				$user = $userFactory->newFromId( intval( $user ) );
 			}
 			if ( !( $user instanceof User ) ) {
 				continue;
 			}
-			if ( $user->isBlocked() ) {
+			if ( $user->getBlock() ) {
 				continue;
 			}
-			$pm = MediaWikiServices::getInstance()->getPermissionManager();
 			if ( $this->title instanceof Title && !$pm->userCan( 'read', $user, $this->title ) ) {
 				continue;
 			} elseif ( !$user->isAllowed( 'read' ) ) {