Fix #150 #151
Merged
Fix #150 #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calculating the height for PrefixListLayout, we were only adding up the heights of each item. When the items is empty or small, the reported height in the final layout would be too small, causing composables under it to draw over the list layout and prefixes. The fix is to also calculate the total height of prefixes and compare with the items height. The bigger of them should be reported as the height of the list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating the height for PrefixListLayout, we were only adding up the heights of each item. When the items is empty or small, the reported height in the final layout would be too small, causing composables under it to draw over the list layout and prefixes.
The fix is to also calculate the total height of prefixes and compare with the items height. The bigger of them should be reported as the height of the list.