Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Move LoweredTableReaderCoercer into ExecuteContext #14696

Open
wants to merge 1 commit into
base: ehigham/http-like-rpc
Choose a base branch
from

Conversation

ehigham
Copy link
Member

@ehigham ehigham commented Sep 20, 2024

Refactored table reader coercion and caching mechanism.

What changed?

  • Removed shouldCacheQueryInfo method from Backend class
  • Introduced CoercerCache in ExecuteContext
  • Refactored LoweredTableReader.makeCoercer to return a function instead of a class
  • Removed local caching in GenericTableValue and LoweredTableReader
  • Added NoCaching utility

Why make this change?

This change aims to optimize table reader coercion by:

  • Centralizing caching logic in ExecuteContext
  • Allowing more flexible caching strategies across different backend implementations

@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from f2c39a6 to 2f3f122 Compare October 1, 2024 19:45
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 16d54bd to 82cd91b Compare October 1, 2024 19:45
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 2f3f122 to b02c83b Compare October 1, 2024 20:03
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 82cd91b to 63191ba Compare October 1, 2024 20:03
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from b02c83b to 20e6520 Compare October 8, 2024 19:19
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 63191ba to dded098 Compare October 8, 2024 19:19
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 20e6520 to e66b858 Compare October 8, 2024 20:30
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from dded098 to 4f3a6e3 Compare October 8, 2024 20:30
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from e66b858 to 49bdf73 Compare October 16, 2024 20:02
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 4f3a6e3 to db7595e Compare October 16, 2024 20:02
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 49bdf73 to 0ce4a09 Compare October 16, 2024 21:30
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from db7595e to 9615ece Compare October 16, 2024 21:30
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 0ce4a09 to 3a671ee Compare October 17, 2024 15:00
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 9615ece to 1951717 Compare October 17, 2024 15:00
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 3a671ee to ee01140 Compare October 21, 2024 15:24
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 1951717 to 3f89fe2 Compare October 21, 2024 15:25
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from ee01140 to 22c3b9b Compare October 21, 2024 18:50
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 3f89fe2 to 1d6e424 Compare October 21, 2024 18:50
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 9270ca3 to 8efd607 Compare October 29, 2024 21:47
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 053a62b to c9a1cc5 Compare October 30, 2024 22:27
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 8efd607 to 561d135 Compare October 30, 2024 22:27
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from c9a1cc5 to 51f8702 Compare October 31, 2024 15:48
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 561d135 to 02e4417 Compare October 31, 2024 15:48
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 51f8702 to cbe8467 Compare November 4, 2024 22:15
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 02e4417 to f2f8332 Compare November 4, 2024 22:15
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from cbe8467 to cc56f09 Compare November 19, 2024 17:08
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from f2f8332 to e03cfac Compare November 19, 2024 17:08
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from cc56f09 to 6bd3033 Compare November 20, 2024 17:01
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from e03cfac to f0bca68 Compare November 20, 2024 17:01
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 6bd3033 to 59ad7bb Compare December 12, 2024 21:51
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from f0bca68 to 718f095 Compare December 12, 2024 21:52
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 59ad7bb to 1408798 Compare December 12, 2024 22:01
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 718f095 to 045f300 Compare December 12, 2024 22:01
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 1408798 to cb9b39e Compare December 12, 2024 22:02
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 045f300 to 5763812 Compare December 12, 2024 22:03
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from cb9b39e to fcf6c67 Compare December 16, 2024 18:49
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 5763812 to 46fbdfc Compare December 16, 2024 18:49
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from fcf6c67 to fc4afd0 Compare December 17, 2024 16:48
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 46fbdfc to 782730e Compare December 17, 2024 16:48
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from fc4afd0 to 2941b77 Compare December 17, 2024 20:00
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 782730e to 5ac288c Compare December 17, 2024 20:00
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 2941b77 to 25101f4 Compare December 17, 2024 20:29
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 5ac288c to 4c6b7bb Compare December 17, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant