-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[query] Move LoweredTableReaderCoercer into ExecuteContext #14696
Open
ehigham
wants to merge
1
commit into
ehigham/http-like-rpc
Choose a base branch
from
ehigham/ctx-coercer-cache
base: ehigham/http-like-rpc
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+379
−379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 20, 2024
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Sep 20, 2024
ehigham
force-pushed
the
ehigham/http-like-rpc
branch
from
October 1, 2024 19:45
f2c39a6
to
2f3f122
Compare
ehigham
force-pushed
the
ehigham/ctx-coercer-cache
branch
from
October 1, 2024 19:45
16d54bd
to
82cd91b
Compare
ehigham
force-pushed
the
ehigham/http-like-rpc
branch
from
October 1, 2024 20:03
2f3f122
to
b02c83b
Compare
ehigham
force-pushed
the
ehigham/ctx-coercer-cache
branch
from
October 1, 2024 20:03
82cd91b
to
63191ba
Compare
ehigham
force-pushed
the
ehigham/http-like-rpc
branch
from
October 8, 2024 19:19
b02c83b
to
20e6520
Compare
ehigham
force-pushed
the
ehigham/ctx-coercer-cache
branch
from
October 8, 2024 19:19
63191ba
to
dded098
Compare
ehigham
force-pushed
the
ehigham/http-like-rpc
branch
from
October 8, 2024 20:30
20e6520
to
e66b858
Compare
ehigham
force-pushed
the
ehigham/ctx-coercer-cache
branch
from
October 8, 2024 20:30
dded098
to
4f3a6e3
Compare
ehigham
force-pushed
the
ehigham/http-like-rpc
branch
from
October 16, 2024 20:02
e66b858
to
49bdf73
Compare
ehigham
force-pushed
the
ehigham/ctx-coercer-cache
branch
from
October 16, 2024 20:02
4f3a6e3
to
db7595e
Compare
ehigham
force-pushed
the
ehigham/http-like-rpc
branch
from
October 16, 2024 21:30
49bdf73
to
0ce4a09
Compare
ehigham
force-pushed
the
ehigham/ctx-coercer-cache
branch
from
October 16, 2024 21:30
db7595e
to
9615ece
Compare
1 task
ehigham
force-pushed
the
ehigham/http-like-rpc
branch
from
October 17, 2024 15:00
0ce4a09
to
3a671ee
Compare
ehigham
force-pushed
the
ehigham/ctx-coercer-cache
branch
from
October 17, 2024 15:00
9615ece
to
1951717
Compare
ehigham
force-pushed
the
ehigham/http-like-rpc
branch
from
October 21, 2024 15:24
3a671ee
to
ee01140
Compare
ehigham
force-pushed
the
ehigham/ctx-coercer-cache
branch
from
October 21, 2024 15:25
1951717
to
3f89fe2
Compare
ehigham
force-pushed
the
ehigham/http-like-rpc
branch
from
October 21, 2024 18:50
ee01140
to
22c3b9b
Compare
ehigham
force-pushed
the
ehigham/ctx-coercer-cache
branch
from
October 21, 2024 18:50
3f89fe2
to
1d6e424
Compare
ehigham
force-pushed
the
ehigham/ctx-coercer-cache
branch
from
October 29, 2024 21:47
9270ca3
to
8efd607
Compare
ehigham
force-pushed
the
ehigham/http-like-rpc
branch
from
October 30, 2024 22:27
053a62b
to
c9a1cc5
Compare
ehigham
force-pushed
the
ehigham/ctx-coercer-cache
branch
from
October 30, 2024 22:27
8efd607
to
561d135
Compare
ehigham
force-pushed
the
ehigham/http-like-rpc
branch
from
October 31, 2024 15:48
c9a1cc5
to
51f8702
Compare
ehigham
force-pushed
the
ehigham/ctx-coercer-cache
branch
from
October 31, 2024 15:48
561d135
to
02e4417
Compare
ehigham
force-pushed
the
ehigham/http-like-rpc
branch
from
November 4, 2024 22:15
51f8702
to
cbe8467
Compare
ehigham
force-pushed
the
ehigham/ctx-coercer-cache
branch
from
November 4, 2024 22:15
02e4417
to
f2f8332
Compare
ehigham
force-pushed
the
ehigham/http-like-rpc
branch
from
November 19, 2024 17:08
cbe8467
to
cc56f09
Compare
ehigham
force-pushed
the
ehigham/ctx-coercer-cache
branch
from
November 19, 2024 17:08
f2f8332
to
e03cfac
Compare
ehigham
force-pushed
the
ehigham/http-like-rpc
branch
from
November 20, 2024 17:01
cc56f09
to
6bd3033
Compare
ehigham
force-pushed
the
ehigham/ctx-coercer-cache
branch
from
November 20, 2024 17:01
e03cfac
to
f0bca68
Compare
This was referenced Dec 5, 2024
ehigham
force-pushed
the
ehigham/http-like-rpc
branch
from
December 12, 2024 21:51
6bd3033
to
59ad7bb
Compare
ehigham
force-pushed
the
ehigham/ctx-coercer-cache
branch
from
December 12, 2024 21:52
f0bca68
to
718f095
Compare
ehigham
force-pushed
the
ehigham/http-like-rpc
branch
from
December 12, 2024 22:01
59ad7bb
to
1408798
Compare
ehigham
force-pushed
the
ehigham/ctx-coercer-cache
branch
from
December 12, 2024 22:01
718f095
to
045f300
Compare
ehigham
force-pushed
the
ehigham/http-like-rpc
branch
from
December 12, 2024 22:02
1408798
to
cb9b39e
Compare
ehigham
force-pushed
the
ehigham/ctx-coercer-cache
branch
from
December 12, 2024 22:03
045f300
to
5763812
Compare
ehigham
force-pushed
the
ehigham/http-like-rpc
branch
from
December 16, 2024 18:49
cb9b39e
to
fcf6c67
Compare
ehigham
force-pushed
the
ehigham/ctx-coercer-cache
branch
from
December 16, 2024 18:49
5763812
to
46fbdfc
Compare
ehigham
force-pushed
the
ehigham/http-like-rpc
branch
from
December 17, 2024 16:48
fcf6c67
to
fc4afd0
Compare
ehigham
force-pushed
the
ehigham/ctx-coercer-cache
branch
from
December 17, 2024 16:48
46fbdfc
to
782730e
Compare
ehigham
force-pushed
the
ehigham/http-like-rpc
branch
from
December 17, 2024 20:00
fc4afd0
to
2941b77
Compare
ehigham
force-pushed
the
ehigham/ctx-coercer-cache
branch
from
December 17, 2024 20:00
782730e
to
5ac288c
Compare
ehigham
force-pushed
the
ehigham/http-like-rpc
branch
from
December 17, 2024 20:29
2941b77
to
25101f4
Compare
ehigham
force-pushed
the
ehigham/ctx-coercer-cache
branch
from
December 17, 2024 20:29
5ac288c
to
4c6b7bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored table reader coercion and caching mechanism.
What changed?
shouldCacheQueryInfo
method fromBackend
classCoercerCache
inExecuteContext
LoweredTableReader.makeCoercer
to return a function instead of a classGenericTableValue
andLoweredTableReader
NoCaching
utilityWhy make this change?
This change aims to optimize table reader coercion by:
ExecuteContext