Skip to content

Commit

Permalink
[auth] Allow ci and monitoring as valid next_urls in auth flows (#14795)
Browse files Browse the repository at this point in the history
## Change Description

Addresses a bug introduced in #14776 which didn't allow `ci` or
`monitoring` as valid "next" urls

## Security Assessment

- This change has a medium security impact

### Impact Description

Additional `next_url`s are allowed, but they are still tightly
constrained to the standard set of hail services.

(Reviewers: please confirm the security impact before approving)
  • Loading branch information
cjllanwarne authored Jan 23, 2025
1 parent 3286e6b commit 260612d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion auth/auth/auth.py
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ def _delete(key):
def validate_next_page_url(next_page):
if not next_page:
raise web.HTTPBadRequest(text='Invalid next page: empty')
valid_next_services = ['batch', 'auth']
valid_next_services = ['batch', 'auth', 'ci', 'monitoring']
valid_next_domains = [urlparse(deploy_config.external_url(s, '/')).netloc for s in valid_next_services]
actual_next_page_domain = urlparse(next_page).netloc

Expand Down

0 comments on commit 260612d

Please sign in to comment.