Skip to content
This repository has been archived by the owner on May 19, 2023. It is now read-only.

Rudradave1/feature/settingsui #56

Open
wants to merge 8 commits into
base: branch_loveleen
Choose a base branch
from
Open

Rudradave1/feature/settingsui #56

wants to merge 8 commits into from

Conversation

rudradave1
Copy link

Settings UI first page

@rudradave1 rudradave1 added the team-loveleen A task assigned to member of team Loveleen label Sep 11, 2022
hadiyarajesh
hadiyarajesh suggested changes Sep 11, 2022
View reviewed changes
Copy link
Owner

@hadiyarajesh hadiyarajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly provide the preview of settings UI

@hadiyarajesh
Copy link
Owner

@rudradave1 why do you want to merge with master ? you must have to merge with your team lead branch.

@rudradave1
Copy link
Author

Kindly provide the preview of settings UI

I have provided SettingsItemPreview for items.
Here is the screenshot of the full UI.
image

@rudradave1
Copy link
Author

@rudradave1 why do you want to merge with master ? you must have to merge with your team lead branch.

I don't want to merge it to master. I created a pull request for branch_loveleen.

@sumanabhi sumanabhi changed the base branch from master to branch_loveleen September 13, 2022 06:09
@sumanabhi
Copy link
Collaborator

sumanabhi commented Sep 13, 2022 •
edited
Loading

@rudradave1 why do you want to merge with master ? you must have to merge with your team lead branch.

I don't want to merge it to master. I created a pull request for branch_loveleen.

I have changed this now.

Please follow the same in future whenever you're creating any PR. Please check where it is pointing out.

@hadiyarajesh
Copy link
Owner

@rudradave1 I've added my comments on #46

Kindly address them, delete that PR and then we're good to merge this PR once @loveleenkaurnancy confirm the same.

rudradave1
rudradave1 commented Oct 1, 2022
View reviewed changes
Copy link
Author

@rudradave1 rudradave1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes updated

@rudradave1 rudradave1 closed this Oct 1, 2022
@rudradave1 rudradave1 reopened this Oct 1, 2022
@hadiyarajesh
Copy link
Owner

@loveleenkaurnancy kindly review and merge the change if it looks good

@hadiyarajesh hadiyarajesh mentioned this pull request Oct 15, 2022
Closed
@hadiyarajesh
Copy link
Owner

@rudradave1 can you rebase your base branch with geet and create a PR for the same?
Also, close #46 if it doesn't require anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hadiyarajesh hadiyarajesh hadiyarajesh requested changes

@loveleenkaurnancy loveleenkaurnancy Awaiting requested review from loveleenkaurnancy

Assignees

@loveleenkaurnancy loveleenkaurnancy

@rudradave1 rudradave1

Labels
team-loveleen A task assigned to member of team Loveleen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rudradave1 @hadiyarajesh @sumanabhi @loveleenkaurnancy