chore(nix): enable the macOS sandbox, with caveats #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like most of the macOS sandbox issues have been resolved, except for the 64K sandbox program limit. Here we enable the sandbox, but in order to work around this limit, we add `/nix/store` to the allowed paths by default. (Presumably the sandbox compiler is smart enough to replace multiple `/nix/store/...` paths with a single `/nix/store` parent path.) This is less than optimal, but much safer than disabling the sandbox entirely, and probably safer than disabling the sandbox on a per-package, as-needed basis, as well. Ref: NixOS/nix#4119 (comment) Also see: NixOS/nixpkgs#346945 NixOS/nix#6836 NixOS/nix#4119 amarshall/home-manager@d7319b7 NixOS/nixpkgs#366245 NixOS/nix#2311 Signed-off-by: Drew Hess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like most of the macOS sandbox issues have been resolved, except for the 64K sandbox program limit.
Here we enable the sandbox, but in order to work around this limit, we add
/nix/storeto the allowed paths by default. (Presumably the sandbox compiler is smart enough to replace multiple/nix/store/...paths with a single/nix/storeparent path.)This is less than optimal, but much safer than disabling the sandbox entirely, and probably safer than disabling the sandbox on a per-package, as-needed basis, as well.
Ref:
NixOS/nix#4119 (comment)
Also see:
NixOS/nixpkgs#346945
NixOS/nix#6836
NixOS/nix#4119
amarshall/home-manager@d7319b7 NixOS/nixpkgs#366245
NixOS/nix#2311