Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating schedule page for during hackathon #11

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Creating schedule page for during hackathon #11

wants to merge 4 commits into from

Conversation

dseum
Copy link
Member

@dseum dseum commented Jun 25, 2023

No description provided.

return convertToTime(end)
}

function disableAutocomplete() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this is doing here, but if you need an input to not use autocomplete, you can simply add it as an attribute. E.g:

<input type="text" autocomplete="off" />

};


function convertToTime(time) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you go through your changes and change anything that handles time and date formatting/processing to date-fns? Documentation does look intimidating at first glance, but understanding the classes and looking at only the methods you need will make it much easier!

@@ -0,0 +1,17 @@
import { writable } from 'svelte/store'


Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you asked about using this store: the way you implemented looks great! I will change it to use the server (Firebase) later, but this is fine in lieu of that for testing. I didn't want to overwhelm by requiring you to implement Firebase; usually, we would use Firebase emulators as a test database.

eventCategoriesJson,
} from '$lib/data'

function convertToMinutes(time) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment about date-fns from line 11 to 51.

@vercel
Copy link

vercel bot commented Sep 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
portal ❌ Failed (Inspect) Sep 14, 2023 9:26pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants