-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating schedule page for during hackathon #11
base: main
Are you sure you want to change the base?
Conversation
src/lib/forms/AddEventForm.svelte
Outdated
return convertToTime(end) | ||
} | ||
|
||
function disableAutocomplete() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what this is doing here, but if you need an input to not use autocomplete, you can simply add it as an attribute. E.g:
<input type="text" autocomplete="off" />
}; | ||
|
||
|
||
function convertToTime(time) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you go through your changes and change anything that handles time and date formatting/processing to date-fns
? Documentation does look intimidating at first glance, but understanding the classes and looking at only the methods you need will make it much easier!
@@ -0,0 +1,17 @@ | |||
import { writable } from 'svelte/store' | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you asked about using this store: the way you implemented looks great! I will change it to use the server (Firebase) later, but this is fine in lieu of that for testing. I didn't want to overwhelm by requiring you to implement Firebase; usually, we would use Firebase emulators as a test database.
eventCategoriesJson, | ||
} from '$lib/data' | ||
|
||
function convertToMinutes(time) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment about date-fns
from line 11 to 51.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
No description provided.