Skip to content

Commit

Permalink
Don't require holding for review to approve/reject
Browse files Browse the repository at this point in the history
An explicit hold's purpose is to just mark that someone is on it, but waiting for something (clarification, edit, etc.), so we shouldn't require it to change a decision.
  • Loading branch information
northeastprince committed Oct 27, 2023
1 parent 1ab6b84 commit e536249
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions app/views/admin/hackathons/show.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,9 @@
</div>

<div class="button-group">
<% if @hackathon.pending? %>
<%= button_to "Approve", admin_hackathon_approval_path(@hackathon), class: "button--success" %>
<%= button_to "Reject", admin_hackathon_rejection_path(@hackathon), class: "button--danger" %>
<% end %>
<% unless @hackathon.pending? %>
<%= button_to "Hold for review", admin_hackathon_hold_path(@hackathon), class: "button--neutral" %>
<% end %>
<%= button_to "Approve", admin_hackathon_approval_path(@hackathon), disabled: @hackathon.approved?, class: "button--success" %>
<%= button_to "Reject", admin_hackathon_rejection_path(@hackathon), disabled: @hackathon.rejected?, class: "button--danger" %>
<%= button_to "Hold for review", admin_hackathon_hold_path(@hackathon), disabled: @hackathon.pending?, class: "button--neutral" %>
</div>

<%= render "events/timeline", {eventable: @hackathon} %>
Expand Down

0 comments on commit e536249

Please sign in to comment.