-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional image #33
Conversation
3ebed83
to
e9e1aa7
Compare
The plan is to add column or the upcoming layout as Accordion content panels. |
@falcon-git That's good. Use #41 then ;-) |
The comment thread regarding adding add image feature in Accordion H5P here and other places, is old yet there is still no Column feature in Accordion or another (simple!) solution for inserting an image in an embedded Content feature. Am I missing something? It is unbelievable that H5P cannot make this happen considering the whole platform is about interactive and technological activities. |
It is now 4 years since this issue was raised - yet I cannot see either columns or images in H5P accordions. Is this ever going to happen? |
Bonjour |
@nahalimedali That would be #41 - still untouched. |
There have been multiple requests to add images to H5P.Accordion, e.g.:
This pull request will allow to add images to accordions, either in addition to text or standalone. Images will scale to full width as usual in H5P. Translations have been updated and an update script to account for changes in semantics has been provided. Also, to allow CSS overrides by users, a wrapper with a style class has been used although there's nothing done.
Since the editor field properties of a library will not be set optional if the use of a library has been set to optional, the editor could be janky if users only want to have text or if they only want to have an image. To solve this problem, a H5P.Column-like approach was used which allows to add multiple content instances to a panel.