Add {{archive_ext}} to support both ".zip" and ".tar.gz" #5
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2022
andreynering
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @gzuidhof,
Thanks for your work on this fork! I tried it today for https://github.com/go-task/task and it seems to work great!
I liked the idea to make it a bundle (using
esbuild) to make it smaller.I missed one thing to make it fully workable, though. On Task we release
.ziparchives on Windows and.tar.gzon the other platforms. This is a common convention on multiples projects. I added support for{{archive_ext}}to make it possible for Windows users to use npm to install the tool.