Fix "Undefined array key _ in Otl.php:1542" (Closes mpdf#1962)

* Fix "Undefined array key _ in Otl.php:1542" --------- Co-authored-by: Mikhailov Nikolai <[email protected]>
gzai · Dec 4, 2023 · 00a35a6 · 00a35a6
1 parent d748f1e
commit 00a35a6
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/src/Otl.php b/src/Otl.php
@@ -1539,6 +1539,10 @@ function _applyGSUBrulesIndic($usetags, $scriptTag, $langsys, $is_old_spec)
 									continue;
 								}
 
+								if (!isset($this->OTLdata[$ptr + 1])) {
+									continue;
+								}
+
 								$nextGlyph = $this->OTLdata[$ptr + 1]['hex'];
 								$nextGID = $this->OTLdata[$ptr + 1]['uni'];
 								if (isset($this->GSLuCoverage[$lu][$c][$nextGID])) {

diff --git a/tests/Issues/Issue1963Test.php b/tests/Issues/Issue1963Test.php
@@ -0,0 +1,25 @@
+<?php
+
+namespace Issues;
+
+use Mpdf\BaseMpdfTest;
+use Mpdf\Mpdf;
+use Mpdf\Output\Destination;
+
+class Issue1963Test extends BaseMpdfTest
+{
+	public function testNoWarning()
+	{
+		$mpdf = new Mpdf([
+			'mode' => '-aCJK',
+			'autoScriptToLang' => true,
+			'autoLangToFont' => true,
+			'default_font' => 'dejavusans',
+		]);
+
+		$mpdf->WriteHTML('<p>न्</p>');
+		$output = $mpdf->OutputBinaryData();
+
+		$this->assertStringStartsWith('%PDF-', $output);
+	}
+}