Speaker rewrite #90
Draft
Speaker rewrite #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is building on my computer I have no idea why the check is failing |
isaacngkh
requested changes
Oct 28, 2024
.wpilib/wpilib_preferences.json
Outdated
| @@ -2,5 +2,5 @@ | |||
| "enableCppIntellisense": false, | |||
| "currentLanguage": "java", | |||
| "projectYear": "2024", | |||
| "teamNumber": 5507 | |||
| return Commands.sequence( | ||
| m_ArmSubsystem.spinArm(armAngle), | ||
| m_PizzaBoxSubsystem.speedyArm_Command((() -> m_ArmSubsystem.getArmAngle())), | ||
| m_PizzaBoxSubsystem.setKicker(), |
There was a problem hiding this comment.
Need to wait until pizza box is up to speed before activating servo
| m_PizzaBoxSubsystem.stopKicker(), | ||
| m_PizzaBoxSubsystem.stopMotor(), | ||
| m_ArmSubsystem.spinArm(90)) | ||
| .withName("scoreAmp"); |
There was a problem hiding this comment.
amp command looks good; test on robot
|
|
||
| return Commands.sequence( | ||
| m_ArmSubsystem.spinArm(25)) | ||
| // m_PizzaBoxSubsystem.speedyArm_Command() |
There was a problem hiding this comment.
source intake command not complete
| public static final double INTAKE_ANGLE = 63; | ||
| public static final double AMP_ANGLE = 160; |
| @@ -65,12 +64,12 @@ public Command stopKicker() { | |||
|
|
|||
| public Command speedyArm_Command(DoubleSupplier f) { | |||
| if (f.getAsDouble() > 99 && f.getAsDouble() < 261) { | |||
| return this.runOnce(() -> pizzaBoxIO.setMotor(1)) | |||
| return this.runOnce(() -> pizzaBoxIO.setMotor(80)) | |||
There was a problem hiding this comment.
setMotor() parameter unit is in percentage -1 to 1; should not be 80.
Also this command is not working as intended; it does not spin the pizzabox while arm is swinging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.