Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and rewrite the OrbotConstants #1216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor and rewrite the OrbotConstants #1216

wants to merge 1 commit into from

Conversation

meenbeese
Copy link
Contributor

  • Rewrite the Java file in Kotlin
  • Use object instead of interface

Tested on Pixel 8 API 34.

@n8fr8 n8fr8 self-assigned this Jan 7, 2025
@meenbeese
Copy link
Contributor Author

I prefer to first merge #1234 and rebase before merging this PR.

@n8fr8
Copy link
Member

n8fr8 commented Jan 15, 2025

#1234 has been merged

@meenbeese
Copy link
Contributor Author

#1234 has been merged

Thanks! Rebased on latest master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@n8fr8 n8fr8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meenbeese @n8fr8