Add event listener to data before piping, add percentage to logs

guardian · Jan 9, 2025 · 95867c1 · 95867c1
1 parent ed1ff8e
commit 95867c1
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/packages/backend-common/src/s3.ts b/packages/backend-common/src/s3.ts
@@ -169,14 +169,16 @@ const downloadS3Data = async (
 	key: string,
 	contentLength?: number,
 ) => {
-	const stream = data.pipe(createWriteStream(destinationPath));
 	let downloadedBytes = 0;
 	data.on('data', (chunk) => {
 		downloadedBytes += chunk.length;
-		logger.info(
-			`Downloaded ${downloadedBytes} of ${contentLength} bytes so far for ${key}`,
-		);
+		if (downloadedBytes > 0 && contentLength && contentLength > 0) {
+			logger.info(
+				`Downloaded ${downloadedBytes} of ${contentLength} bytes so far ${contentLength ? `(${Math.floor(downloadedBytes / contentLength)}%)` : ''} for ${key}`,
+			);
+		}
 	});
+	const stream = data.pipe(createWriteStream(destinationPath));
 	await new Promise<void>((resolve, reject) => {
 		stream
 			.on('finish', () => {