Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move AB test types #6752

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Move AB test types #6752

merged 2 commits into from
Feb 3, 2025

Conversation

tomrf1
Copy link
Member

@tomrf1 tomrf1 commented Jan 31, 2025

Moves the types from abTests/abtest.ts into a separate abTests/models.ts file:

  1. because abtest.ts is a very long file,
  2. I want to avoid circular dependencies in some upcoming work on AB testing.

Copy link
Contributor

Size Change: -28 B (0%)

Total Size: 1.89 MB

ℹ️ View Unchanged
Filename Size Change
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 90.3 kB +3 B (0%)
./public/compiled-assets/javascripts/[countryGroupId]/router.js 93.4 kB -9 B (-0.01%)
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB +1 B (0%)
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 222 kB -1 B (0%)
./public/compiled-assets/javascripts/downForMaintenancePage.js 67.3 kB -2 B (0%)
./public/compiled-assets/javascripts/error404Page.js 67.3 kB -2 B (0%)
./public/compiled-assets/javascripts/error500Page.js 67.2 kB -1 B (0%)
./public/compiled-assets/javascripts/favicons.js 617 B 0 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 163 kB -3 B (0%)
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 87.6 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPage.js 65.9 kB -1 B (0%)
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./public/compiled-assets/javascripts/promotionTerms.js 73.5 kB -1 B (0%)
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 72.9 kB 0 B
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 118 kB -3 B (0%)
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 160 kB -3 B (0%)
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 88.2 kB +1 B (0%)
./public/compiled-assets/webpack/114.js 12.2 kB 0 B
./public/compiled-assets/webpack/127.js 3.53 kB 0 B
./public/compiled-assets/webpack/136.js 2.17 kB 0 B
./public/compiled-assets/webpack/163.js 8.9 kB 0 B
./public/compiled-assets/webpack/187.js 19.9 kB -4 B (-0.02%)
./public/compiled-assets/webpack/192.js 5.69 kB 0 B
./public/compiled-assets/webpack/276.js 4.39 kB 0 B
./public/compiled-assets/webpack/344.js 2 kB 0 B
./public/compiled-assets/webpack/445.js 6.87 kB 0 B
./public/compiled-assets/webpack/492.js 7.58 kB 0 B
./public/compiled-assets/webpack/706.js 107 kB 0 B
./public/compiled-assets/webpack/719.js 13.5 kB 0 B
./public/compiled-assets/webpack/847.js 26 kB 0 B
./public/compiled-assets/webpack/969.js 37.8 kB 0 B
./public/compiled-assets/webpack/checkout.js 17 kB 0 B
./public/compiled-assets/webpack/GuardianAdLiteLanding.js 8.27 kB 0 B
./public/compiled-assets/webpack/LandingPage.js 15.5 kB -2 B (-0.01%)
./public/compiled-assets/webpack/oneTimeCheckout.js 6.07 kB -1 B (-0.02%)
./public/compiled-assets/webpack/ThankYou.js 44.4 kB 0 B

compressed-size-action

@tomrf1 tomrf1 merged commit d2c8177 into main Feb 3, 2025
19 checks passed
@tomrf1 tomrf1 deleted the tf-ab-models branch February 3, 2025 09:17
@prout-bot
Copy link

Seen on PROD (merged by @tomrf1 9 minutes and 56 seconds ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants