Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a higher threshold alarm which we can use for known checkout failure reasons #6749

Merged
merged 6 commits into from
Jan 31, 2025

Conversation

tjmw
Copy link
Member

@tjmw tjmw commented Jan 30, 2025

What are you doing in this PR?

This PR adds a new higher threshold alarm/metric.

Trello Card

Why are you doing this?

In #6745 we stopped alarming on the "email already taken" error from identity. It's a known issue and we don't want to spend time investigating every time it happens. However, we would like to know if it starts occurring at a higher volume. This PR adds the concept of a higher threshold alarm/metric which we can use to cover this case. The alarm will trigger if 10 or more minutes in the last hour have errors.

How to test

Forcing the "email already taken" error locally I see the following in the logs:

pushing higher threshold alarm metric for 500 Some(email_address_already_taken)

I could also see the new metric in Cloudwatch:

Screenshot 2025-01-30 at 13 04 24

How can we measure success?

Have we considered potential risks?

Accessibility test checklist

Screenshots

tjmw added 2 commits January 30, 2025 12:44
For example, we don't care about every instance of "email already taken"
from Identity, but we want to know if there are suddenly lots of them.
Copy link
Contributor

github-actions bot commented Jan 30, 2025

Size Change: 0 B

Total Size: 1.89 MB

ℹ️ View Unchanged
Filename Size
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 90.3 kB
./public/compiled-assets/javascripts/[countryGroupId]/router.js 93.4 kB
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 222 kB
./public/compiled-assets/javascripts/downForMaintenancePage.js 67.3 kB
./public/compiled-assets/javascripts/error404Page.js 67.3 kB
./public/compiled-assets/javascripts/error500Page.js 67.2 kB
./public/compiled-assets/javascripts/favicons.js 617 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 163 kB
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 87.6 kB
./public/compiled-assets/javascripts/payPalErrorPage.js 65.9 kB
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B
./public/compiled-assets/javascripts/promotionTerms.js 73.5 kB
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 72.9 kB
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 118 kB
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 160 kB
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 88.1 kB
./public/compiled-assets/webpack/114.js 12.2 kB
./public/compiled-assets/webpack/127.js 3.53 kB
./public/compiled-assets/webpack/136.js 2.17 kB
./public/compiled-assets/webpack/163.js 8.9 kB
./public/compiled-assets/webpack/187.js 19.9 kB
./public/compiled-assets/webpack/192.js 5.69 kB
./public/compiled-assets/webpack/276.js 4.39 kB
./public/compiled-assets/webpack/344.js 2 kB
./public/compiled-assets/webpack/445.js 6.87 kB
./public/compiled-assets/webpack/492.js 7.58 kB
./public/compiled-assets/webpack/706.js 107 kB
./public/compiled-assets/webpack/719.js 13.5 kB
./public/compiled-assets/webpack/847.js 26 kB
./public/compiled-assets/webpack/969.js 37.8 kB
./public/compiled-assets/webpack/checkout.js 17 kB
./public/compiled-assets/webpack/GuardianAdLiteLanding.js 8.27 kB
./public/compiled-assets/webpack/LandingPage.js 15.5 kB
./public/compiled-assets/webpack/oneTimeCheckout.js 6.07 kB
./public/compiled-assets/webpack/ThankYou.js 44.4 kB

compressed-size-action

tjmw added 4 commits January 30, 2025 13:10
Alarm fires if 10 out of the last 60 minutes had >= 1 error of this
type.
Copy link
Contributor

@andrewHEguardian andrewHEguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@tjmw tjmw merged commit dbf6953 into main Jan 31, 2025
16 checks passed
@tjmw tjmw deleted the tw/high-threshold-alarm branch January 31, 2025 10:51
@prout-bot
Copy link

Seen on PROD (merged by @tjmw 8 minutes and 52 seconds ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants