-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a higher threshold alarm which we can use for known checkout failure reasons #6749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, we don't care about every instance of "email already taken" from Identity, but we want to know if there are suddenly lots of them.
Size Change: 0 B Total Size: 1.89 MB ℹ️ View Unchanged
|
Alarm fires if 10 out of the last 60 minutes had >= 1 error of this type.
For testing in CODE.
andrewHEguardian
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍
Seen on PROD (merged by @tjmw 8 minutes and 52 seconds ago)
Sentry Release: support-client-side, support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you doing in this PR?
This PR adds a new higher threshold alarm/metric.
Trello Card
Why are you doing this?
In #6745 we stopped alarming on the "email already taken" error from identity. It's a known issue and we don't want to spend time investigating every time it happens. However, we would like to know if it starts occurring at a higher volume. This PR adds the concept of a higher threshold alarm/metric which we can use to cover this case. The alarm will trigger if 10 or more minutes in the last hour have errors.
How to test
Forcing the "email already taken" error locally I see the following in the logs:
I could also see the new metric in Cloudwatch:
How can we measure success?
Have we considered potential risks?
Accessibility test checklist
Screenshots