Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove digisub gift references from client side #6747

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

andrewHEguardian
Copy link
Contributor

@andrewHEguardian andrewHEguardian commented Jan 30, 2025

What are you doing in this PR?

Removing any references to digisub gifting from the client side after it was removed from the server (#6736)

Trello Card

How to test

  • Run through E2E tests
  • Check digisub routes (/subscribe/digital redirects to /contribute through fastly)

Copy link
Contributor

Size Change: -549 B (-0.03%)

Total Size: 1.89 MB

ℹ️ View Unchanged
Filename Size Change
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 90.3 kB -28 B (-0.03%)
./public/compiled-assets/javascripts/[countryGroupId]/router.js 93.4 kB -16 B (-0.02%)
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB -1 B (0%)
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 222 kB -50 B (-0.02%)
./public/compiled-assets/javascripts/downForMaintenancePage.js 67.3 kB -37 B (-0.05%)
./public/compiled-assets/javascripts/error404Page.js 67.3 kB -34 B (-0.05%)
./public/compiled-assets/javascripts/error500Page.js 67.2 kB -32 B (-0.05%)
./public/compiled-assets/javascripts/favicons.js 617 B 0 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 163 kB -47 B (-0.03%)
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 87.6 kB -33 B (-0.04%)
./public/compiled-assets/javascripts/payPalErrorPage.js 65.9 kB -35 B (-0.05%)
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./public/compiled-assets/javascripts/promotionTerms.js 73.5 kB -47 B (-0.06%)
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 72.9 kB -30 B (-0.04%)
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 118 kB -35 B (-0.03%)
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 160 kB -57 B (-0.04%)
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 88.1 kB -45 B (-0.05%)
./public/compiled-assets/webpack/136.js 2.17 kB 0 B
./public/compiled-assets/webpack/186.js 3.35 kB 0 B
./public/compiled-assets/webpack/187.js 19.9 kB -12 B (-0.06%)
./public/compiled-assets/webpack/219.js 39.3 kB -10 B (-0.03%)
./public/compiled-assets/webpack/276.js 4.39 kB 0 B
./public/compiled-assets/webpack/3.js 19.2 kB 0 B
./public/compiled-assets/webpack/344.js 2 kB 0 B
./public/compiled-assets/webpack/397.js 10.2 kB 0 B
./public/compiled-assets/webpack/592.js 36.5 kB 0 B
./public/compiled-assets/webpack/706.js 107 kB 0 B
./public/compiled-assets/webpack/719.js 13.5 kB 0 B
./public/compiled-assets/webpack/754.js 10.1 kB 0 B
./public/compiled-assets/webpack/847.js 26 kB 0 B
./public/compiled-assets/webpack/checkout.js 13.6 kB 0 B
./public/compiled-assets/webpack/GuardianAdLiteLanding.js 10.1 kB 0 B
./public/compiled-assets/webpack/LandingPage.js 17.2 kB 0 B
./public/compiled-assets/webpack/oneTimeCheckout.js 6.08 kB 0 B
./public/compiled-assets/webpack/ThankYou.js 1.05 kB 0 B

compressed-size-action

@@ -17,23 +17,6 @@ export const pageUrlRegexes = {
genericCheckoutOnly: '(uk|us|au|ca|eu|nz|int)/checkout|thank-you(/.*)?$',
},
subscriptions: {
subsDigiSubPages: '(/??/subscribe(\\?.*)?$|/??/subscribe/digital(\\?.*)?$)',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all are irrelevant now because the digisub page is at /subscribe/digitaledition

Copy link
Member

@tjmw tjmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👏

@andrewHEguardian andrewHEguardian merged commit e4e46c3 into main Jan 30, 2025
19 checks passed
@andrewHEguardian andrewHEguardian deleted the ahe/remove-digisub-gift branch January 30, 2025 14:14
@prout-bot
Copy link

Seen on PROD (merged by @andrewHEguardian 10 minutes and 6 seconds ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants