Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighthouse - remove third party resource count #6737

Merged

Conversation

andrewHEguardian
Copy link
Contributor

What are you doing in this PR?

Removing the assertion of third party resource count from our lighthouse CI action, after refactoring the router in #6733 it's been bumped up to 33. But this doesn't seem like a metric worth tracking

Screenshots

Example of what these are from the generated report
image

@andrewHEguardian andrewHEguardian requested a review from tjmw January 27, 2025 16:24
Copy link
Contributor

Size Change: 0 B

Total Size: 1.89 MB

ℹ️ View Unchanged
Filename Size
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 90.3 kB
./public/compiled-assets/javascripts/[countryGroupId]/router.js 93.4 kB
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 222 kB
./public/compiled-assets/javascripts/downForMaintenancePage.js 67.3 kB
./public/compiled-assets/javascripts/error404Page.js 67.3 kB
./public/compiled-assets/javascripts/error500Page.js 67.2 kB
./public/compiled-assets/javascripts/favicons.js 617 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 163 kB
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 87.6 kB
./public/compiled-assets/javascripts/payPalErrorPage.js 66 kB
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B
./public/compiled-assets/javascripts/promotionTerms.js 73.6 kB
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 73 kB
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 118 kB
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 160 kB
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 88.2 kB
./public/compiled-assets/webpack/136.js 2.17 kB
./public/compiled-assets/webpack/186.js 3.35 kB
./public/compiled-assets/webpack/187.js 19.9 kB
./public/compiled-assets/webpack/219.js 39.2 kB
./public/compiled-assets/webpack/276.js 4.39 kB
./public/compiled-assets/webpack/3.js 19.2 kB
./public/compiled-assets/webpack/344.js 2 kB
./public/compiled-assets/webpack/397.js 10.2 kB
./public/compiled-assets/webpack/592.js 36.3 kB
./public/compiled-assets/webpack/706.js 107 kB
./public/compiled-assets/webpack/719.js 13.5 kB
./public/compiled-assets/webpack/754.js 10.2 kB
./public/compiled-assets/webpack/847.js 26 kB
./public/compiled-assets/webpack/checkout.js 13.5 kB
./public/compiled-assets/webpack/GuardianAdLiteLanding.js 9.67 kB
./public/compiled-assets/webpack/LandingPage.js 17.2 kB
./public/compiled-assets/webpack/oneTimeCheckout.js 6.08 kB
./public/compiled-assets/webpack/ThankYou.js 1.05 kB

compressed-size-action

Copy link
Contributor

@GHaberis GHaberis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@andrewHEguardian andrewHEguardian merged commit cc9b796 into main Jan 27, 2025
16 checks passed
@andrewHEguardian andrewHEguardian deleted the ahe/lighthouse-remove-third-party-resource-count branch January 27, 2025 16:36
@prout-bot
Copy link

Seen on PROD (merged by @andrewHEguardian 9 minutes and 22 seconds ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants