Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some cookies set by the checkout #6714

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tjmw
Copy link
Member

@tjmw tjmw commented Jan 22, 2025

What are you doing in this PR?

I've removed the following as they're no longer needed:

  • gu_recurring_contributor
  • gu_digital_subscriber
  • gu.contributions.recurring.contrib-timestamp.<billing period>

I've refactored the cookie setting code a bit to consolidate things and make it clear where products set the same cookie(s).

Trello Card

Why are you doing this?

These cookies are no longer needed.

How to test

Put through a purchase, see that these cookies are no longer set.

I've removed the following as they're no longer used:
* gu_recurring_contributor
* gu_digital_subscriber
* gu.contributions.recurring.contrib-timestamp.<billing period>

I've refactored the cookie setting code a bit to consolidate things and
make it clear where products set the same cookie(s).
@tjmw tjmw requested a review from rupertbates January 22, 2025 12:34
Copy link
Contributor

Size Change: 0 B

Total Size: 2.36 MB

ℹ️ View Unchanged
Filename Size
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 90.5 kB
./public/compiled-assets/javascripts/[countryGroupId]/lazyRouter.js 93.2 kB
./public/compiled-assets/javascripts/[countryGroupId]/router.js 254 kB
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 223 kB
./public/compiled-assets/javascripts/downForMaintenancePage.js 67.7 kB
./public/compiled-assets/javascripts/error404Page.js 67.6 kB
./public/compiled-assets/javascripts/error500Page.js 67.5 kB
./public/compiled-assets/javascripts/favicons.js 617 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 164 kB
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 87.9 kB
./public/compiled-assets/javascripts/payPalErrorPage.js 66.1 kB
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B
./public/compiled-assets/javascripts/promotionTerms.js 73.8 kB
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 73.2 kB
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 118 kB
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 226 kB
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 160 kB
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 88 kB
./public/compiled-assets/webpack/136.js 2.17 kB
./public/compiled-assets/webpack/186.js 3.35 kB
./public/compiled-assets/webpack/187.js 21.7 kB
./public/compiled-assets/webpack/3.js 19.2 kB
./public/compiled-assets/webpack/311.js 40.1 kB
./public/compiled-assets/webpack/344.js 2.01 kB
./public/compiled-assets/webpack/397.js 10.2 kB
./public/compiled-assets/webpack/426.js 36.5 kB
./public/compiled-assets/webpack/643.js 22.4 kB
./public/compiled-assets/webpack/706.js 107 kB
./public/compiled-assets/webpack/754.js 9.96 kB
./public/compiled-assets/webpack/847.js 26 kB
./public/compiled-assets/webpack/checkout.js 14.3 kB
./public/compiled-assets/webpack/GuardianAdLiteLanding.js 9.05 kB
./public/compiled-assets/webpack/oneTimeCheckout.js 9.96 kB
./public/compiled-assets/webpack/ThankYou.js 1.08 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant