Add fields required for Guardian Ad Lite thank you email #6642
+40
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjmw
commented
Dec 19, 2024
|
|
||
| object GuardianLightSubscriptionBuilder { | ||
| // The user isn't charged until day 15 | ||
| val gracePeriodInDays = 15 |
There was a problem hiding this comment.
Pulled this out to make it easy to share with the code which builds the email fields.
|
Size Change: 0 B Total Size: 2.23 MB ℹ️ View Unchanged
|
tjmw
changed the title
tjmw
commented
Dec 20, 2024
| "email_address" -> state.user.primaryEmailAddress, | ||
| "billing_period" -> state.product.billingPeriod.toString.toLowerCase, | ||
| "first_payment_date" -> formatDate( | ||
| created.plusDays(GuardianLightSubscriptionBuilder.gracePeriodInDays).toLocalDate, |
There was a problem hiding this comment.
@rupertbates this date logic is also here. I'm sharing the grace period value but I wonder if there's a better way of doing this? Any thoughts?
|
Seen on PROD (merged by @tjmw 11 minutes and 17 seconds ago)
Sentry Release: support-client-side, support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you doing in this PR?
This PR adds the fields required for the thank you email. These will be provided as API trigger properties to the Braze campaign.
Trello Card
Why are you doing this?
Currently Guardian Ad-Lite emails are not configured and we want to send thank you emails to users who purchase.
How to test
I've deployed this PR and guardian/membership-workflow#561 to CODE and made a purchase. The email triggered successfully.
How can we measure success?
Have we considered potential risks?
Accessibility test checklist
Screenshots