-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove react-day-picker #6638
Remove react-day-picker #6638
Conversation
Size Change: -53.9 kB (-2.41%) Total Size: 2.19 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even better
Now we're no longer using it.
It was only ever called from checkGiftStartDate, which we were only using for Digipack Gift subs, which we don't support any more.
e9b2a19
to
72eac18
Compare
Seen on PROD (merged by @tjmw 10 minutes and 45 seconds ago)
Sentry Release: support-client-side, support |
What are you doing in this PR?
Remove
react-day-picker
NPM packageand replace with our own implementation.and the method which uses it (it's no longer needed, as it was only ever used for Digipack Gift subs which we no longer support).Trello Card
Why are you doing this?
The version of
react-day-picker
we're on is 5 years old, and the interface has changed. The only code paths which use it are no longer needed.How to test
I took this approach:1. Make the existing method (which does usereact-day-picker
) testable, by allowing passing innow
2. Add some tests3. Update the method, removingreact-day-picker
and ensure tests still passHow can we measure success?
Have we considered potential risks?
Accessibility test checklist
Screenshots