Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated M25 postcode list #6259

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

graham228221
Copy link
Contributor

@graham228221 graham228221 commented Aug 27, 2024

What are you doing in this PR?

Aligns the postcodes defined as "inside M25" for the Newspaper Home Delivery product to the list of postcodes provided by Customer Operations.

Also combines the previous two lists into one list, as previously suggested here. It's a bit difficult to maintain two separate lists, and the way postcodes are validated should mean that having every variation of postcode area + subdistrict is not required (and actually is more risky - DA22 does not equal DA2 2!).

Why are you doing this?

Latest "Inside M25" delivery list from Customer Operations:

Screenshot 2024-08-27 at 14 33 22

How to test

How can we measure success?

Have we considered potential risks?

Accessibility test checklist

Screenshots

Copy link
Contributor

Size Change: 0 B

Total Size: 2.24 MB

ℹ️ View Unchanged
Filename Size
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 99.6 kB
./public/compiled-assets/javascripts/[countryGroupId]/router.js 252 kB
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 240 kB
./public/compiled-assets/javascripts/downForMaintenancePage.js 69.3 kB
./public/compiled-assets/javascripts/error404Page.js 69.3 kB
./public/compiled-assets/javascripts/error500Page.js 69.2 kB
./public/compiled-assets/javascripts/favicons.js 618 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 195 kB
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 86.1 kB
./public/compiled-assets/javascripts/payPalErrorPage.js 67.8 kB
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B
./public/compiled-assets/javascripts/promotionTerms.js 72.4 kB
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 71.5 kB
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 126 kB
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 307 kB
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 198 kB
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 86.1 kB
./public/compiled-assets/webpack/385.js 81.8 kB
./public/compiled-assets/webpack/630.js 2.03 kB
./public/compiled-assets/webpack/740.js 19.8 kB
./public/compiled-assets/webpack/775.js 18.1 kB
./public/compiled-assets/webpack/991.js 2.17 kB

compressed-size-action

@graham228221 graham228221 added the Do Not Merge May still be WIP or unstable label Aug 27, 2024
@graham228221
Copy link
Contributor Author

I've compiled the removed postcodes from the diff and sent to customer operations team to double-check. Bit confused that we'd remove some postcodes that were only added in 2022 🤔 maybe the National Delivery supplier is their preferred option for these boundary areas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge May still be WIP or unstable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant