-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated M25 postcode list #6259
Draft
graham228221
wants to merge
1
commit into
main
Choose a base branch
from
gh-correct-m25-postcodes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 2.24 MB ℹ️ View Unchanged
|
I've compiled the removed postcodes from the diff and sent to customer operations team to double-check. Bit confused that we'd remove some postcodes that were only added in 2022 🤔 maybe the National Delivery supplier is their preferred option for these boundary areas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you doing in this PR?
Aligns the postcodes defined as "inside M25" for the Newspaper Home Delivery product to the list of postcodes provided by Customer Operations.
Also combines the previous two lists into one list, as previously suggested here. It's a bit difficult to maintain two separate lists, and the way postcodes are validated should mean that having every variation of postcode area + subdistrict is not required (and actually is more risky - DA22 does not equal DA2 2!).
Why are you doing this?
Latest "Inside M25" delivery list from Customer Operations:
How to test
How can we measure success?
Have we considered potential risks?
Accessibility test checklist
Screenshots