This repository was archived by the owner on May 12, 2022. It is now read-only.
Add version 0.1.0 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fuller service description.
nicl
force-pushed
the
nl-add-note-on-api-formats
branch
from
1f969eb to
694fdc1
Compare
| [/service/gtg](#gtg) | ||
| [/service/dependencies](#dependencies) | ||
|
|
||
| These resources should be presented on port 8080 (not port 80). |
There was a problem hiding this comment.
Definitely not port 80, as that implies root permissions, nginx, and all kinds of hassle.
Is this implicitly saying that the service should expose its HTTP API on port 8080 and the management interface should be on the same port as that? If so, I would explicitly state both things, but make both of them SHOULD rather than MUST.
There was a problem hiding this comment.
The problem with SHOULD is that how do we build tools to inspect these endpoints if we don't know the ports?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fuller service description.