An/teal overquota leased warning #4404
Draft
+12
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes a bug in the indicator of what % of selected images have been leased (some problem with interpolating in a "style" attribute during webpack production mode; works fine locally but completely broken in production. Couldn't find the root cause, so switch to using
ng-style)Then, change the colour of the validity warning message which applies when the image has restrictions or is overquota etc. to teal, so that it is clearer that the warnings have been overridden and the image can be used (usually because a lease has been applied).
How should a reviewer test this change?
How can success be measured?
Who should look at this?
Tested? Documented?