update undelete poller to poll for undeletions, not deletions #4397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Roughly the same as #4389, but for the undelete button (since each are in different implementation files).
How should a reviewer test this change?
Upload an image, delete it and then undelete it. Before this PR, there should be ongoing polling looking for the file to have been deleted (but since deletions are implemented using soft-deleted-metadata, and this button is for making an image be not deleted, it cannot ever resolve).
How can success be measured?
Less unnecessary requests from client.
Who should look at this?
Tested? Documented?