Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move from GH pages to @guardian/actions-static-site #130

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

twrichards
Copy link
Contributor

@twrichards twrichards commented Jun 4, 2024

Given recent stability issues with GitHub pages, it made sense to host using https://github.com/guardian/actions-static-site
for consistency with the rest of the estate and deployments via riff-raff. Oh an we get Google auth 😃

Note that it's already used for https://tools.gutools.co.uk/ (https://github.com/guardian/tools-index, specifically https://github.com/guardian/tools-index/pull/138)

Additional Tasks

  • ensure action has access to secrets.GU_RIFF_RAFF_ROLE_ARN - https://github.com/guardian/riffraff-platform/pull/165
  • have the domain added to the Google project
  • remove old DNS entry and deploy this manually to PROD first time
  • set-up Continuous Deployment in riff-raff
  • turn-off GH Pages hosting in settings of this repo (and delete the gh-pages branch I guess)

@twrichards twrichards changed the title move from GH pages to https://github.com/guardian/actions-static-site move from GH pages to @guardian/actions-static-site Jun 4, 2024
@twrichards twrichards force-pushed the actions-static-site branch 2 times, most recently from 5214eb5 to 732d5c4 Compare June 4, 2024 08:44
path: dist
- uses: guardian/actions-static-site@v2
with:
app: editions-card-builder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's non-obvious that this repository will be deployed with the Riff-Raff project deploy::editions-card-builder. Worth adding something to the README?

@twrichards twrichards force-pushed the actions-static-site branch from 732d5c4 to 6c9094e Compare June 4, 2024 09:00
@rhystmills
Copy link

I'm not sure how to test this, any advice?

@twrichards
Copy link
Contributor Author

I'm not sure how to test this, any advice?

Can't really test. Deploying without removing existing DNS entry will fail as it attempts to create GuCname. Here it is in riff-raff though...
image
...I've had a look at the artifacts that will get deployed in https://riffraff.gutools.co.uk/deployment/request/deployFiles?projectName=deploy%3A%3Aeditions-card-builder&id=140 and all looks fine to me.

Just waiting on getting the domain added to the allow list in the Google project.

@twrichards
Copy link
Contributor Author

I'm inclined to deploy to PROD manually first time, before merging the PR.

- uses: guardian/actions-static-site@v2
with:
app: editions-card-builder
domain: editions-card-builder.gutools.co.uk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test by deploying to this or some other alternative name first, then switching later? to avoid bringing down the real thing which is still accessible by some ISPs. hopefully the site doesn't hardcode its domain anywhere

Suggested change
domain: editions-card-builder.gutools.co.uk
domain: editions-card-builder-2.gutools.co.uk

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test by deploying to this or some other alternative name first, then switching later? to avoid bringing down the real thing which is still accessible by some ISPs. hopefully the site doesn't hardcode its domain anywhere

I thought about this, but that leaves behind detritus in the deployTools account, plus DevX will need to add the domain to the google account and remove after. If somebody from @guardian/digital-cms would like to please review, and they also don't want to take the risk then I'm happy to do Andrew's suggestion and pair with DevX to cleanup after.

@twrichards
Copy link
Contributor Author

twrichards commented Jun 11, 2024

Manually deployed to PROD via actions-static-site. Thank you to @jacobwinch for DNS changes and pairing on the release.
image

@twrichards twrichards merged commit 7e26a7e into main Jun 11, 2024
1 check passed
@twrichards twrichards deleted the actions-static-site branch June 11, 2024 12:10
@prout-bot
Copy link

Overdue on PROD (merged by @twrichards 10 minutes and 4 seconds ago) What's gone wrong?

twrichards added a commit that referenced this pull request Jun 25, 2024
noticed PRout was reporting overdue on #130 despite CD being configured in riff-raff... turns out CI action didn't run for main (which made sense when using gh-pages)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants