Podcast series image on cards #13072
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
|
Size Change: +205 B (+0.02%) Total Size: 938 kB
ℹ️ View Unchanged
|
jamesmockett
reviewed
Jan 7, 2025
Comment on lines
+140
to
+142
| (imageType === 'picture' || | ||
| imageType === 'video' || | ||
| imageType === 'podcast') && |
There was a problem hiding this comment.
The conditional immediately before this seems to be applying exactly the same same styles just for slideshows so could be added to this?
imageType === 'slideshow' &&
isHorizontalOnDesktop &&
flexBasisStyles({
imageSize,
}), }),
jamesmockett
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Renders the podcast series image when the media is type podcast if the series image is provided.
It also adds a wrapper around the image to fix the size of a podcast series image.
Why?
This is as per designs.
Screenshots