Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crossword input box same height as grid cell #1879

Draft
wants to merge 1 commit into
base: mob/tabbing-around-the-crossword
Choose a base branch
from
Draft

Crossword input box same height as grid cell #1879

wants to merge 1 commit into from

Conversation

oliverabrahams
Copy link
Contributor

What are you changing?

  • Make the input cell the same height as the grid cell

Why?

  • This prevents the grid input from moving the page on a smaller container. Previously it would center the input which was the full height of the grid.

@oliverabrahams oliverabrahams requested a review from a team as a code owner January 6, 2025 09:31
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2025

⚠️ No Changeset found

Latest commit: 47c2120

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Jan 6, 2025
@oliverabrahams oliverabrahams changed the title make input box same height as grid cell Crossword input box same height as grid cell Jan 6, 2025
@oliverabrahams oliverabrahams marked this pull request as draft January 7, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
📦 npm Affects a @guardian package on NPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oliverabrahams