Use one fsevent_watch process per listener instead of one per dir
#470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 2, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Warning: unrecognized cop Lint/LiteralInCondition found in .rubocop.yml
Warning: unrecognized cop Lint/LiteralInCondition found in .rubocop.yml Error: RuboCop found unsupported Ruby version 2.2 in `TargetRubyVersion` parameter (in .rubocop.yml). 2.2-compatible analysis was dropped after version 0.69. Supported versions: 2.3, 2.4, 2.5, 2.6, 2.7
|
Yeah, we should definitely fix this. |
tgxworld
force-pushed
the
reduce_multiple_fsevent_processes
branch
from
56fb995 to
5764592
Compare
houndci-bot
reviewed
Dec 5, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Warning: unrecognized cop Lint/LiteralInCondition found in .rubocop.yml
Warning: unrecognized cop Lint/LiteralInCondition found in .rubocop.yml Error: RuboCop found unsupported Ruby version 2.2 in `TargetRubyVersion` parameter (in .rubocop.yml). 2.2-compatible analysis was dropped after version 0.69. Supported versions: 2.3, 2.4, 2.5, 2.6, 2.7
tgxworld
force-pushed
the
reduce_multiple_fsevent_processes
branch
from
5764592 to
2952cb8
Compare
houndci-bot
reviewed
Dec 5, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Warning: unrecognized cop Lint/LiteralInCondition found in .rubocop.yml
Warning: unrecognized cop Lint/LiteralInCondition found in .rubocop.yml Error: RuboCop found unsupported Ruby version 2.2 in `TargetRubyVersion` parameter (in .rubocop.yml). 2.2-compatible analysis was dropped after version 0.69. Supported versions: 2.3, 2.4, 2.5, 2.6, 2.7
tgxworld
force-pushed
the
reduce_multiple_fsevent_processes
branch
from
2952cb8 to
7722b1b
Compare
houndci-bot
reviewed
Dec 5, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Warning: unrecognized cop Lint/LiteralInCondition found in .rubocop.yml
Warning: unrecognized cop Lint/LiteralInCondition found in .rubocop.yml Error: RuboCop found unsupported Ruby version 2.2 in `TargetRubyVersion` parameter (in .rubocop.yml). 2.2-compatible analysis was dropped after version 0.69. Supported versions: 2.3, 2.4, 2.5, 2.6, 2.7
tgxworld
force-pushed
the
reduce_multiple_fsevent_processes
branch
from
7722b1b to
6711547
Compare
houndci-bot
reviewed
Dec 5, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Warning: unrecognized cop Lint/LiteralInCondition found in .rubocop.yml
Warning: unrecognized cop Lint/LiteralInCondition found in .rubocop.yml Error: RuboCop found unsupported Ruby version 2.2 in `TargetRubyVersion` parameter (in .rubocop.yml). 2.2-compatible analysis was dropped after version 0.69. Supported versions: 2.3, 2.4, 2.5, 2.6, 2.7
tgxworld
force-pushed
the
reduce_multiple_fsevent_processes
branch
from
6711547 to
e094dba
Compare
houndci-bot
reviewed
Dec 5, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Warning: unrecognized cop Lint/LiteralInCondition found in .rubocop.yml
Warning: unrecognized cop Lint/LiteralInCondition found in .rubocop.yml Error: RuboCop found unsupported Ruby version 2.2 in `TargetRubyVersion` parameter (in .rubocop.yml). 2.2-compatible analysis was dropped after version 0.69. Supported versions: 2.3, 2.4, 2.5, 2.6, 2.7
tgxworld
commented
Dec 5, 2019
tgxworld
force-pushed
the
reduce_multiple_fsevent_processes
branch
from
e094dba to
188579a
Compare
houndci-bot
reviewed
Dec 5, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Warning: unrecognized cop Lint/LiteralInCondition found in .rubocop.yml
Warning: unrecognized cop Lint/LiteralInCondition found in .rubocop.yml Error: RuboCop found unsupported Ruby version 2.2 in `TargetRubyVersion` parameter (in .rubocop.yml). 2.2-compatible analysis was dropped after version 0.69. Supported versions: 2.3, 2.4, 2.5, 2.6, 2.7
tgxworld
force-pushed
the
reduce_multiple_fsevent_processes
branch
from
188579a to
6c16cb2
Compare
houndci-bot
reviewed
Dec 5, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Warning: unrecognized cop Lint/LiteralInCondition found in .rubocop.yml
Warning: unrecognized cop Lint/LiteralInCondition found in .rubocop.yml Error: RuboCop found unsupported Ruby version 2.2 in `TargetRubyVersion` parameter (in .rubocop.yml). 2.2-compatible analysis was dropped after version 0.69. Supported versions: 2.3, 2.4, 2.5, 2.6, 2.7
tgxworld
commented
Dec 5, 2019
| rel_path = new_path.relative_path_from(dir).to_s | ||
| _queue_change(:dir, dir, rel_path, recursive: true) | ||
| def _process_changes(dirs) | ||
| dirs.each do |dir| |
There was a problem hiding this comment.
I'm aware there are two loops here but for the average use case, this is going to consist of only a couple of directories that change each time.
|
@ioquatix Would you mind reviewing this? Thank you so much! 🙇 |
|
I will review it tonight. |
|
Thank you so much 👍 |
|
Using local branch: #471 |
johncip
added a commit
to napolif/commission-reporter
that referenced
this pull request
Mar 22, 2020
I'm running into wacky amounts of CPU usage and want to rule this out as a cause: rails/rails#26158 guard/listen#470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: rails/rails#26158, rails/rails#37269
This is an attempt to resolve the problem of too many
fsevent_watchevents being spun up on OSX since the number of processes increases with the number of directories being watched.