Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

Add a GError derive macro #367

Merged
merged 4 commits into from
Mar 21, 2021
Merged

Add a GError derive macro #367

merged 4 commits into from
Mar 21, 2021

Conversation

elmarco
Copy link
Contributor

@elmarco elmarco commented Mar 19, 2021

No description provided.

@elmarco elmarco mentioned this pull request Mar 19, 2021
Open
sdroege
sdroege reviewed Mar 20, 2021
View reviewed changes
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, thanks!

glib-macros/src/lib.rs Show resolved Hide resolved
glib-macros/src/lib.rs Outdated Show resolved Hide resolved
glib-macros/src/gerror_derive.rs Outdated Show resolved Hide resolved
glib-macros/src/gerror_derive.rs Outdated Show resolved Hide resolved
glib-macros/src/gerror_derive.rs Outdated Show resolved Hide resolved
@elmarco
glib: reexport once_cell
74ab2e3 
glib-macros want to be able to use it

Signed-off-by: Marc-André Lureau <[email protected]>
@elmarco elmarco force-pushed the gerror branch 2 times, most recently from b1a1433 to 0d90b2a Compare March 20, 2021 15:40
sdroege
sdroege reviewed Mar 20, 2021
View reviewed changes
glib/src/quark.rs Outdated Show resolved Hide resolved
sdroege
sdroege reviewed Mar 20, 2021
View reviewed changes
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a small test to glib-macros/tests, like the existing ones? Then we can at least be sure that it compiles and kind of behaves (e.g. you can create a glib::Error from it).

@elmarco
glib-macros: add a gerror_domain test
8358f59 
Signed-off-by: Marc-André Lureau <[email protected]>
@elmarco
Copy link
Contributor Author

elmarco commented Mar 20, 2021

Can you also add a small test to glib-macros/tests, like the existing ones? Then we can at least be sure that it compiles and kind of behaves (e.g. you can create a glib::Error from it).

done (it was partially covered by doc already)

@sdroege sdroege merged commit 71cd8b9 into gtk-rs:master Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

@sdroege sdroege sdroege approved these changes

@bilelmoussaoui bilelmoussaoui Awaiting requested review from bilelmoussaoui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elmarco @sdroege @GuillaumeGomez