Automatically assume that win32_ and unix_ should use the related cfg
#1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
force-pushed
the
gen-cfg-automatically
branch
from
c2aa3c8 to
e002b34
Compare
sdroege
reviewed
Jan 29, 2024
sdroege
reviewed
Jan 29, 2024
src/update_cfgs.rs
Outdated
| None => Some("windows".to_string()), | ||
| Some(cfg) => Some(format!("{cfg},windows")), | ||
| } | ||
| } else if sub_object_name.starts_with("Unix") { |
There was a problem hiding this comment.
Maybe also UNIX (all-uppercase)?
|
Generated code seems fine to me |
|
@GuillaumeGomez Are the are Windows/UNIX cfgs left in gtk-rs-core |
|
Yes. I only did it for gio iirc. |
GuillaumeGomez
force-pushed
the
gen-cfg-automatically
branch
from
e002b34 to
45a6bd2
Compare
|
Updated: it now takes into account the namespace the type comes from. Nothing to do for constants: their (non-c) name doesn't have a prefix apparently. |
sdroege
approved these changes
Feb 5, 2024
|
I'll send PRs to other projects next. |
This was referenced Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can take a look at the result here (I didn't remove all unneeded
cfg_conditionyet).