Fix sonar issues

grrolland · Nov 20, 2023 · dc19fce · dc19fce
1 parent 33d9aaf
commit dc19fce
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 34 deletions.
diff --git a/README.md b/README.md
@@ -1,7 +1,7 @@
 [![Build](https://github.com/grrolland/ngx-distributed-shm/actions/workflows/build.yml/badge.svg?branch=master)](https://github.com/grrolland/ngx-distributed-shm/actions/workflows/build.yml)
-[![Quality Gate](https://sonarcloud.io/api/project_badges/measure?project=io.github.grrolland%3Angx-distributed-shm&metric=alert_status)](https://sonarcloud.io/dashboard/index/io.github.grrolland:ngx-distributed-shm)
-[![Technical debt ratio](https://sonarcloud.io/api/project_badges/measure?project=io.github.grrolland%3Angx-distributed-shm&metric=sqale_index)](https://sonarcloud.io/dashboard/index/io.github.grrolland:ngx-distributed-shm)
-[![Coverage](https://sonarcloud.io/api/project_badges/measure?project=io.github.grrolland%3Angx-distributed-shm&metric=coverage)](https://sonarcloud.io/dashboard/index/io.github.grrolland:ngx-distributed-shm)
+[![Reliability Rating](https://sonarcloud.io/api/project_badges/measure?project=grrolland_ngx-distributed-shm&metric=reliability_rating)](https://sonarcloud.io/summary/new_code?id=grrolland_ngx-distributed-shm)
+[![Bugs](https://sonarcloud.io/api/project_badges/measure?project=grrolland_ngx-distributed-shm&metric=bugs)](https://sonarcloud.io/summary/new_code?id=grrolland_ngx-distributed-shm)
+[![Vulnerabilities](https://sonarcloud.io/api/project_badges/measure?project=grrolland_ngx-distributed-shm&metric=vulnerabilities)](https://sonarcloud.io/summary/new_code?id=grrolland_ngx-distributed-shm)
 [![Release](https://img.shields.io/github/release/grrolland/ngx-distributed-shm)](https://github.com/grrolland/ngx-distributed-shm/tags/)
 
 # ngx-distributed-shm

diff --git a/src/main/java/io/github/grrolland/hcshm/ShmProtocolHandler.java b/src/main/java/io/github/grrolland/hcshm/ShmProtocolHandler.java
@@ -97,42 +97,38 @@ public ShmProtocolHandler(NetSocket socket, ShmService service) {
      */
     @Override
     public void handle(Buffer buffer) {
-    	if (buffer != null && logger.isDebugEnabled()) {
-    		logger.debug("handling buffer [{}]", buffer.toString(PROTOCOL_ENCODING));
-    	}
-        if (expectedMode == FrameMode.COMMAND) {
+        if (null != buffer) {
+            if (logger.isDebugEnabled()) {
+                logger.debug("handling buffer [{}]", buffer.toString(PROTOCOL_ENCODING));
+            }
+            if (expectedMode == FrameMode.COMMAND) {
 
-            final String[] commandTokens = buffer.toString(PROTOCOL_ENCODING).split(COMMAND_LINE_DELIMITER);
-            currentCommand = commandFactory.get(commandTokens);
-            final String result = currentCommand.execute(commandTokens);
+                final String[] commandTokens = buffer.toString(PROTOCOL_ENCODING).split(COMMAND_LINE_DELIMITER);
+                currentCommand = commandFactory.get(commandTokens);
+                final String result = currentCommand.execute(commandTokens);
 
-            socket.write(result, PROTOCOL_ENCODING);
+                socket.write(result, PROTOCOL_ENCODING);
 
-            if (currentCommand.isTerminationCommand()) {
-                socket.close();
-            }
-            else if (currentCommand.needsDataPart())
-            {
-                expectedMode = FrameMode.DATA;
-                parser.fixedSizeMode(currentCommand.getDataPartSize());
-            }
-            else
-            {
+                if (currentCommand.isTerminationCommand()) {
+                    socket.close();
+                } else if (currentCommand.needsDataPart()) {
+                    expectedMode = FrameMode.DATA;
+                    parser.fixedSizeMode(currentCommand.getDataPartSize());
+                } else {
+                    expectedMode = FrameMode.COMMAND;
+                    parser.delimitedMode(PROTOCOL_DELIMITER);
+                }
+
+            } else {
+                final String result = currentCommand.executeDataPart(buffer.toString(PROTOCOL_ENCODING));
+                socket.write(result, PROTOCOL_ENCODING);
                 expectedMode = FrameMode.COMMAND;
                 parser.delimitedMode(PROTOCOL_DELIMITER);
             }
-
-        }
-        else {
-            final String result = currentCommand.executeDataPart(buffer.toString(PROTOCOL_ENCODING));
-            socket.write(result, PROTOCOL_ENCODING);
-            expectedMode = FrameMode.COMMAND;
-            parser.delimitedMode(PROTOCOL_DELIMITER);
+            if (logger.isDebugEnabled()) {
+                logger.debug("Done handling buffer [{}]", buffer.toString(PROTOCOL_ENCODING));
+            }
         }
-    	if (buffer != null && logger.isDebugEnabled()) {
-    		logger.debug("Done handling buffer [{}]", buffer.toString(PROTOCOL_ENCODING));
-    	}
-
     }
 
     /**

diff --git a/src/main/java/io/github/grrolland/hcshm/ShmTcpServer.java b/src/main/java/io/github/grrolland/hcshm/ShmTcpServer.java
@@ -46,7 +46,7 @@ public ShmTcpServer() {
      * @throws Exception unable to start the server
      */
     @Override
-    public void start() throws Exception {
+    public void start() {
         NetServerOptions options = new NetServerOptions().setPort(Configuration.getPort()).setHost(Configuration.getBindAddress());
         NetServer server = vertx.createNetServer(options);
         server.connectHandler(sock -> ShmProtocolHandler.create(sock, service));

diff --git a/src/main/java/io/github/grrolland/hcshm/processor/TouchProcessor.java b/src/main/java/io/github/grrolland/hcshm/processor/TouchProcessor.java
@@ -50,7 +50,6 @@ public TouchProcessor(int expire) {
     @Override
     public Object process(Map.Entry<String, ShmValue> entry) {
         final ShmValue r = entry.getValue();
-        final String key = entry.getKey();
         if (null != r) {
             r.expire(expire);
         	((ExtendedMapEntry<String, ShmValue>) entry).setValue(r, expire, TimeUnit.SECONDS);